smithy-go icon indicating copy to clipboard operation
smithy-go copied to clipboard

Support renamed errors in aws-json-1.1 protocol

Open everett1992 opened this issue 2 years ago • 1 comments

Describe the feature

Smithy recently allowed renaming error shapes but added a validator to prevent renamed errors with aws protocols.

Most aws protocols only use shape name in error serialization, which is why error renames were originally banned. However, aws json 1.0 uses qualified shape id and can support renamed errors.

The protocol should match errors based on the original (not renamed) fully qualified shape id.

Once all smithy sdk's (rust, js, go, kotlin) confirm that aws json 1.0 supports renamed errors smithy can remove the protocol from the validator and allow renames.

https://github.com/awslabs/smithy/issues/1545

Use Case

I have smithy a smithy model with shapes with conflicting names, tho the qualified shape id is unique. I'd like to use aws json 1.0 protocol, which could support renamed error shapes, but the validator throws an error.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • [ ] I may be able to implement this feature request
  • [ ] This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

N/A

Go version used

N/A

everett1992 avatar Jan 05 '23 00:01 everett1992

Hi @everett1992 we will add it to the backlog. Currently there is no timeline for implementation.

Thank you. Ran~

RanVaknin avatar Mar 09 '23 23:03 RanVaknin