serverless-java-container icon indicating copy to clipboard operation
serverless-java-container copied to clipboard

Make compatible with Jakarta namespace

Open farazhv opened this issue 2 years ago • 1 comments

Issue #, if available:

Multipart form upload is not supported

Description of changes: Compatible with Jakarta namespace

By submitting this pull request

  • [x] I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • [x] I confirm that I've made a best effort attempt to update all relevant documentation.

farazhv avatar Sep 30 '22 13:09 farazhv

With reference to issue: https://github.com/awslabs/aws-serverless-java-container/issues/477

farazhv avatar Sep 30 '22 13:09 farazhv

Thank you for pointing this out.

Since this branch was based on an earlier commit of the master branch, it didn’t include the most recent change. My last commit to this branch addresses this and resolves the merge conflict.

We are using the submitted code in a lambda to host our webserver – so it is working for our purposes as-is, as we don’t need multipart support.

farazhv avatar Oct 14 '22 08:10 farazhv

@deki Is there any timeline in place to get these changes sorted, merged and released? Got a Spring Boot 3 application which I'm planning to move to AWS Lambda, so am wondering if I need to go and tinker it myself, or put it on the back burner until the new release.

tntsoft avatar Jan 02 '23 15:01 tntsoft

Hi folks, sorry for the delay but we finally made the changes in the main branch.

@farazhv while comparing with your PR, I notice a NullInputStream and some changes related to binary reading? Is that needed? Could you please test the main branch if it's working for you?

deki avatar Apr 25 '23 15:04 deki

@deki sure we will test the main branch as soon as we can

farazhv avatar Apr 25 '23 15:04 farazhv

We released a 2.0.0-M1 version today. Please continue testing and open a new PR with the remaining changes if needed.

deki avatar May 19 '23 15:05 deki

@deki we aren't blocked by this so we won't be able to test it for the time being

farazhv avatar May 24 '23 20:05 farazhv