serverless-application-model icon indicating copy to clipboard operation
serverless-application-model copied to clipboard

fix(lambda): correcting changeset detection

Open Vandita2020 opened this issue 9 months ago • 3 comments

Issue #, if available

Description of changes

With the updates to the parameter values, the changes were not reflected when the changeSet got created, the issue was with the condition used to check if the update is being made.

Previously, the code used type == "Update" to validate if the action was an update, but it should have been changeset_type == "Update".

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Vandita2020 avatar Mar 24 '25 06:03 Vandita2020

Do you mind providing PR links to any related changes or bug issues for context?

vicheey avatar Mar 24 '25 17:03 vicheey

It's interesting that this is a bug, but it's not related to an issue we discussed offline. So I don't know exactly what this will do (because this only affects SAM's integration tests, and nothing else).

valerena avatar Mar 24 '25 21:03 valerena

It's interesting that this is a bug, but it's not related to an issue we discussed offline. So I don't know exactly what this will do (because this only affects SAM's integration tests, and nothing else).

@valerena do you a link/sim to the issue we discussed offline?

seshubaws avatar Apr 28 '25 21:04 seshubaws