sagemaker-training-toolkit icon indicating copy to clipboard operation
sagemaker-training-toolkit copied to clipboard

feature: add python module entrypoint type, add python module support…

Open clumsy opened this issue 1 year ago • 1 comments

Issue #, if available:

Related to https://github.com/aws/sagemaker-python-sdk/pull/4324

Description of changes: torchrun can run modules via -m <MODULE but SageMaker runtime does not yet support this entrypoint type. Adding a new entrypoint type and add support to torch_distributed.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • [x] I have updated any necessary documentation, including READMEs

Tests

  • [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

clumsy avatar Mar 19 '24 19:03 clumsy

/Bot run all

emeraldbay avatar Mar 20 '24 14:03 emeraldbay