sagemaker-spark icon indicating copy to clipboard operation
sagemaker-spark copied to clipboard

Un-necessary arguments required for SageMakerEstimator when Endpoint creation is not required

Open AnshumanRanjan opened this issue 6 years ago • 1 comments

Please fill out the form below.

System Information

  • Spark or PySpark: Spark
  • SDK Version: Master
  • Spark Version: All
  • Algorithm (e.g. KMeans): All

Describe the problem

When creating SageMakerEstimator class , if the EndpointCreationPolicy is not required or set to DO_NOT_CREATE , we should not be specifying arguments like : requestRowSerializer responseRowDeserializer modelEnvironmentVariables

Since they do not have any defaults

Minimal repo / logs

This is a design fix request so that user does not have to provide information to the constructor when there is no requirement for creation of endpoint

  • Exact command to reproduce: NA

AnshumanRanjan avatar May 01 '18 15:05 AnshumanRanjan

Thanks for the suggestion! We'll look into making this change, but can't promise it'll happen anytime soon. If this is something you'd like to see sooner, would you be interested in submitting a PR?

laurenyu avatar May 02 '18 22:05 laurenyu