sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

Feature: add sklearn 1.2.1.1 and xgboost 1.7.1.1

Open lxning opened this issue 3 months ago • 2 comments

Issue #, if available: For python upgrade 3.10, add sm sklearn container 1.2.1.1 and sm xgboost container 1.7.1.1

Description of changes: Add sm xgboost container: 1.7-1-1, and sklearn container 1.2-1-1

Testing done: tox -e py310 -- tests/unit

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [ ] I used the commit message format described in CONTRIBUTING
  • [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • [ ] If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lxning avatar Sep 25 '25 18:09 lxning

Reading from the error logs of the unit test, seems that you need to change the version string from 1.2-1-1 to 1.2.1-1

ref:

_ ERROR collecting tests/unit/sagemaker/cli/compatibility/v2/modifiers/test_training_input.py _
.tox/py39/lib/python3.9/site-packages/pluggy/_hooks.py:513: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
.tox/py39/lib/python3.9/site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
.tox/py39/lib/python3.9/site-packages/_pytest/python.py:249: in pytest_pycollect_makeitem
    res = list(collector._genfunctions(name, obj))
.tox/py39/lib/python3.9/site-packages/_pytest/python.py:470: in _genfunctions
    self.ihook.pytest_generate_tests.call_extra(methods, dict(metafunc=metafunc))
.tox/py39/lib/python3.9/site-packages/pluggy/_hooks.py:574: in call_extra
    return self._hookexec(self.name, hookimpls, kwargs, firstresult)
.tox/py39/lib/python3.9/site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
tests/conftest.py:729: in pytest_generate_tests
    _generate_all_framework_version_fixtures(metafunc)
tests/conftest.py:740: in _generate_all_framework_version_fixtures
    _parametrize_framework_version_fixtures(metafunc, fw, config[image_scope])
tests/conftest.py:793: in _parametrize_framework_version_fixtures
    latest_version = sorted(config["versions"].keys(), key=lambda v: Version(v))[-1]
tests/conftest.py:793: in <lambda>
    latest_version = sorted(config["versions"].keys(), key=lambda v: Version(v))[-1]
.tox/py39/lib/python3.9/site-packages/packaging/version.py:202: in __init__
    raise InvalidVersion(f"Invalid version: {version!r}")
E   packaging.version.InvalidVersion: Invalid version: '1.2-1-1'

mollyheamazon avatar Oct 08 '25 23:10 mollyheamazon

Hi, as part of incoming PySDK V3 release, master branch will be replaced by PySDK V3 code. We have changed the target branch to master-v2

zhaoqizqwang avatar Nov 19 '25 21:11 zhaoqizqwang