sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

doc: Fix import path of the `PySparkProcessor`

Open gcbeltramini opened this issue 1 year ago • 1 comments

Issue #, if available: --

Description of changes:

  • Fix import path of PySparkProcessor
  • Fix typo

Testing done: Ran locally:

from sagemaker.spark.processing import PySparkProcessor
import sagemaker

print(sagemaker.__version__)  # 2.198.0

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x] I used the commit message format described in CONTRIBUTING
  • [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • [ ] If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

gcbeltramini avatar Dec 27 '24 21:12 gcbeltramini

@adonig is attempting to deploy a commit to the Aoyue Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 26 '25 10:06 vercel[bot]

This is a good strategy. Here's an unpublished reference:

import type { Pattern } from 'fast-glob'
import { Options as ExtractorOptions } from '@master/css-extractor'

/* The default options */
const options: PluginOptions = {
    mode: 'runtime',
    config: 'master.css',
    injectNormalCSS: true,
    injectRuntime: true,
    injectVirtualModule: true,
    avoidFOUC: true,
}

export default options

export interface PluginOptions {
    /**
     * Defines how Master CSS should be integrated into the build.
     *
     * - `'runtime'`: Detects the application's entry file, automatically injects the initialization of CSSRuntime, and imports the config code.
     * - `'extract'`: Detects the application's entry file, automatically imports the `virtual:master.css` module, and triggers the static extraction workflow.
     * - `'pre-render'`: Renders all `*.html` dependencies and injects CSS internally. This mode may be integrated with other SSR capabilities.
     * - `'progressive'`: Combines `'runtime'` and `'pre-render'` modes.
     * - `null`: Disables automatic integration
     */
    mode?: 'runtime' | 'extract' | 'progressive' | 'pre-render' | null

    /**
     * Glob pattern(s) or extractor options for the static extraction mode
     *
     * - Provide a glob `Pattern` to manually specify your extractor config.
     * - Or provide `ExtractorOptions` for fine-grained extractor configuration.
     */
    extractor?: ExtractorOptions | Pattern

    /**
     * Path to the Master CSS config file.
     * Defaults to `'master.css'`.
     */
    config?: string

    /**
     * Whether to inject the `@master/normal.css` module into the entry file.
     */
    injectNormalCSS?: boolean

    /**
     * Whether to include Master CSS’s runtime engine into the entry file.
     */
    injectRuntime?: boolean

    /**
     * Whether to register the virtual module `virtual:master.css`.
     * Allows importing it directly in user code for dynamic injection.
     */
    injectVirtualModule?: boolean

    /**
     * Prevents Flash of Unstyled Content (FOUC) during the initial render.
     * Useful in Runtime
     */
    avoidFOUC?: boolean
}

Perhaps we just need to disable automatic injection and let developers import the modules manually as they normally would.

1aron avatar Jun 26 '25 11:06 1aron