sagemaker-python-sdk fix: fixed implementation of fail_on_violation for transform with monitoring

fix: fixed implementation of fail_on_violation for transform with monitoring

Open keshav-chandak opened this issue 6 months ago • 6 comments

Issue #, if available:

Description of changes: Implemeted the fail_on_violation for the transform_with_monitoring step for sagemaker.transformer

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
[x] I used the commit message format described in CONTRIBUTING
[x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)
[x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Feb 21 '24 08:02 keshav-chandak

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 688a37dcc6d57ac43b5c0adfce23f5a522fba76f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 21 '24 09:02 mufaddal-rohawala

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 688a37dcc6d57ac43b5c0adfce23f5a522fba76f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 21 '24 09:02 mufaddal-rohawala

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 688a37dcc6d57ac43b5c0adfce23f5a522fba76f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 21 '24 10:02 mufaddal-rohawala

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 688a37dcc6d57ac43b5c0adfce23f5a522fba76f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 21 '24 10:02 mufaddal-rohawala

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.15%. Comparing base (8b206ba) to head (88ab7ee). Report is 38 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4442      +/-   ##
==========================================
+ Coverage   86.94%   87.15%   +0.20%     
==========================================
  Files        1203      387     -816     
  Lines      107211    35777   -71434     
==========================================
- Hits        93211    31180   -62031     
+ Misses      14000     4597    -9403

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.