sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

Fix model explainability one time schedule

Open hightensan opened this issue 6 months ago • 0 comments

Issue #, if available: Fix for - https://github.com/aws/sagemaker-python-sdk/issues/4431

Description of changes:

  • Add data_analysis_start_time and data_analysis_end_time in ModelExplainabilityMonitor's _create_monitoring_schedule_from_job_definition
  • Add unit test code test_model_explainability_monitor_with_one_time_schedule and _test_model_explainability_monitor_create_one_time_schedule to test ModelExplainabilityMonitor's one-time schedule

Testing done:

  • Unit test done as $ tox -e py39 -- -s -vv tests/unit/sagemaker/monitor/test_clarify_model_monitor.py::test_model_explainability_monitor_with_one_time_schedule

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x] I used the commit message format described in CONTRIBUTING
  • [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hightensan avatar Feb 17 '24 13:02 hightensan