sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

feature: Add transformers 4.32.0 - PyTorch 2.0.0

Open oleksiishevchuk opened this issue 1 year ago • 18 comments

Issue #4075, if available:

Description of changes: Update Image URI for: Transformers 4.32 - PyTorch 2.0 Inference DLC Transformers 4.32 - PyTorch 2.0 Training DLC

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x] I used the commit message format described in CONTRIBUTING
  • [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

oleksiishevchuk avatar Aug 19 '23 12:08 oleksiishevchuk

/bot run all

oleksiishevchuk avatar Aug 19 '23 13:08 oleksiishevchuk

Hi. Can somebody please run tests?

oleksiishevchuk avatar Aug 21 '23 20:08 oleksiishevchuk

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b490ba4285ea5da9b9a558aedff5f4d6d6782353
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Aug 28 '23 19:08 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b490ba4285ea5da9b9a558aedff5f4d6d6782353
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Aug 28 '23 19:08 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b490ba4285ea5da9b9a558aedff5f4d6d6782353
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Aug 28 '23 19:08 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b490ba4285ea5da9b9a558aedff5f4d6d6782353
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Aug 28 '23 21:08 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b490ba4285ea5da9b9a558aedff5f4d6d6782353
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Aug 28 '23 21:08 sagemaker-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8d5d7fd) 90.44% compared to head (b8bf0a5) 90.35%. Report is 103 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4076      +/-   ##
==========================================
- Coverage   90.44%   90.35%   -0.10%     
==========================================
  Files         990      312     -678     
  Lines       87006    28676   -58330     
==========================================
- Hits        78692    25909   -52783     
+ Misses       8314     2767    -5547     

see 1302 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 28 '23 21:08 codecov-commenter

Same failure as in https://github.com/aws/sagemaker-python-sdk/pull/3904#issuecomment-1595181446

sagemaker.exceptions.UnexpectedStatusException: Error for Training job huggingface-pytorch-training-2023-08-28-20-14-36-905: Failed. Reason: ClientError: Data download failed:API error (404): manifest for 763104351884.dkr.ecr.us-west-2.amazonaws.com/huggingface-pytorch-training:2.0.0-transformers4.32.0-gpu-py310-cu118-ubuntu20.04 not found: manifest unknown: Requested image not found

Needs an update about image availability - https://github.com/aws/sagemaker-python-sdk/pull/3904#issuecomment-1678075674

oleksiishevchuk avatar Aug 29 '23 09:08 oleksiishevchuk

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b490ba4285ea5da9b9a558aedff5f4d6d6782353
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Aug 31 '23 22:08 sagemaker-bot

@oleksiishevchuk Need to fix the issues associated with

E           sagemaker.exceptions.UnexpectedStatusException: Error for Training job huggingface-pytorch-training-2023-08-31-21-12-47-618: Failed. Reason: ClientError: TrainingHostAgent Initialization failed:API error (404): manifest for 763104351884.dkr.ecr.us-west-2.amazonaws.com/huggingface-pytorch-training:2.0.0-transformers4.32.0-gpu-py310-cu118-ubuntu20.04 not found: manifest unknown: Requested image not found

mufaddal-rohawala avatar Aug 31 '23 22:08 mufaddal-rohawala

Only sagemaker-python-sdk-pr tests is yet to be validated for this PR.

mufaddal-rohawala avatar Aug 31 '23 22:08 mufaddal-rohawala

Thanks @mufaddal-rohawala , please see my comment above about this issue https://github.com/aws/sagemaker-python-sdk/pull/4076#issuecomment-1697094893

oleksiishevchuk avatar Sep 01 '23 13:09 oleksiishevchuk

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b8bf0a573c7666e9d02c97c9e4ee740e18a478d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 26 '23 03:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b8bf0a573c7666e9d02c97c9e4ee740e18a478d7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 26 '23 03:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b8bf0a573c7666e9d02c97c9e4ee740e18a478d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 26 '23 03:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b8bf0a573c7666e9d02c97c9e4ee740e18a478d7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 26 '23 04:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b8bf0a573c7666e9d02c97c9e4ee740e18a478d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 26 '23 04:10 sagemaker-bot

@oleksiishevchuk Please open this issue with DLC who is an upstream dependency to release these images and then we can rework on this PR. Meanwhile I advice you to use latest PyTorch which comes with transformers 4.36.0

knikure avatar Mar 08 '24 06:03 knikure