change: Add PipelineVariable annotation to Amazon estimators

Open qidewenwhen opened this issue 1 year ago • 6 comments

Description of changes:

Add PipelineVariable annotation in Amazon Estimator subclasses. The PipelineVariable annotation will be leveraged by a test mechanism: https://github.com/aws/sagemaker-python-sdk/pull/3163 to scan and check the incompatible issues between Pipeline steps and downstream classes caused by pipeline variables.
Fix issues figured out by the test mechanism.

Testing done: unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[X] I have read the CONTRIBUTING doc
[X] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
[X] I used the commit message format described in CONTRIBUTING
[X] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[X] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[X] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[X] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[X] I have checked that my tests are not configured for a specific region or account (if appropriate)
[X] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sep 22 '22 01:09 qidewenwhen

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 059f7ffe0fe93b8512fd50b289600d16b06c059d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 22 '22 02:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 059f7ffe0fe93b8512fd50b289600d16b06c059d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 22 '22 02:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 059f7ffe0fe93b8512fd50b289600d16b06c059d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 22 '22 02:09 sagemaker-bot

Codecov Report

Merging #3373 (35e8a0a) into master (b4ea839) will decrease coverage by 0.85%. The diff coverage is 98.05%.

@@            Coverage Diff             @@
##           master    #3373      +/-   ##
==========================================
- Coverage   90.01%   89.15%   -0.86%     
==========================================
  Files         868      204     -664     
  Lines       76892    19002   -57890     
==========================================
- Hits        69213    16942   -52271     
+ Misses       7679     2060    -5619

Impacted Files	Coverage Δ
src/sagemaker/amazon/amazon_estimator.py	`87.82% <81.25%> (ø)`
src/sagemaker/amazon/lda.py	`98.03% <92.30%> (ø)`
src/sagemaker/amazon/factorization_machines.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/ipinsights.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/kmeans.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/knn.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/linear_learner.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/ntm.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/object2vec.py	`99.05% <100.00%> (ø)`
src/sagemaker/amazon/pca.py	`100.00% <100.00%> (ø)`
... and 1073 more