sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

Published 20 hours ago • verified publisher icon aws

fix(local-mode): loosen docker requirement to allow 6.0.0

Open jmahlik opened this issue 1 year ago • 1 comments

Issue #, if available: Closes #3326

Description of changes: Makes using local mode more friendly with python 3.10. Docker 6.0.0 has quite a few bug fixes as well. Users can still pin to docker <6 if there are any corner cases.

https://github.com/docker/docker-py/releases/tag/6.0.0

Testing done: Installed docker 6.0.0. Ran local tests on python 3.10. Waiting to see how the ci pans out since I didn't have a role set up to pull images for the integ tests.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

n/a

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jmahlik avatar Sep 21 '22 01:09 jmahlik

Commenting on why >=5.0.2, 5.0.1 was a bad release. https://github.com/aws/sagemaker-python-sdk/pull/2614

jmahlik avatar Sep 21 '22 01:09 jmahlik

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 61d53bcfc2966e79acb003b9d04639355684ff1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 23 '22 22:09 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 61d53bcfc2966e79acb003b9d04639355684ff1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 23 '22 23:09 sagemaker-bot

Codecov Report

Merging #3370 (e0000bb) into master (1fa2377) will decrease coverage by 0.02%. The diff coverage is 95.17%.

@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
- Coverage   89.17%   89.14%   -0.03%     
==========================================
  Files         204      204              
  Lines       18979    19010      +31     
==========================================
+ Hits        16924    16947      +23     
- Misses       2055     2063       +8
Impacted Files Coverage Δ
src/sagemaker/session.py 71.41% <28.57%> (-0.25%) :arrow_down:
src/sagemaker/estimator.py 89.43% <71.42%> (-0.08%) :arrow_down:
src/sagemaker/amazon/amazon_estimator.py 87.82% <81.25%> (-0.62%) :arrow_down:
src/sagemaker/amazon/lda.py 98.03% <92.30%> (+0.16%) :arrow_up:
src/sagemaker/amazon/factorization_machines.py 100.00% <100.00%> (ø)
src/sagemaker/amazon/ipinsights.py 100.00% <100.00%> (ø)
src/sagemaker/amazon/kmeans.py 100.00% <100.00%> (ø)
src/sagemaker/amazon/knn.py 100.00% <100.00%> (ø)
src/sagemaker/amazon/linear_learner.py 100.00% <100.00%> (ø)
src/sagemaker/amazon/ntm.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 23 '22 23:09 codecov-commenter

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 61d53bcfc2966e79acb003b9d04639355684ff1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 23 '22 23:09 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 61d53bcfc2966e79acb003b9d04639355684ff1f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 23 '22 23:09 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 61d53bcfc2966e79acb003b9d04639355684ff1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 24 '22 00:09 sagemaker-bot

From what I can tell, this is some flakey notebook tests failing.

jmahlik avatar Sep 30 '22 19:09 jmahlik

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e0000bbc872aef3da9c783b70f6b35d397231835
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 07 '22 16:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e0000bbc872aef3da9c783b70f6b35d397231835
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 07 '22 16:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e0000bbc872aef3da9c783b70f6b35d397231835
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 07 '22 16:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e0000bbc872aef3da9c783b70f6b35d397231835
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 07 '22 16:10 sagemaker-bot

Can also confirm I've run our internal test suites for custom images that use sagemaker local mode on python 3.10 and docker 6.0.0 and they checked out.

jmahlik avatar Oct 07 '22 18:10 jmahlik

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e0000bbc872aef3da9c783b70f6b35d397231835
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 07 '22 18:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e0000bbc872aef3da9c783b70f6b35d397231835
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 10 '22 01:10 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e0000bbc872aef3da9c783b70f6b35d397231835
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Oct 10 '22 03:10 sagemaker-bot