sagemaker-python-sdk icon indicating copy to clipboard operation
sagemaker-python-sdk copied to clipboard

fix: Fixing the logic to return instanceCount for heterogeneousClusters

Open asumitamazon opened this issue 1 year ago • 6 comments

We recently started supporting feature for heterogeneousClusters and missed this part where we return instanceCount from ResourceConfig -> InstanceType For heterogeneousCluster jobs the total instanceCount is sum total of the instanceCount of all the instance groups. Fixing the same.

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [ ] I used the commit message format described in CONTRIBUTING
  • [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

asumitamazon avatar Sep 16 '22 17:09 asumitamazon

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6754ef9910294cf5fdb7787cfeb384608f2ac2a4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 20 '22 21:09 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6754ef9910294cf5fdb7787cfeb384608f2ac2a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 20 '22 21:09 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6754ef9910294cf5fdb7787cfeb384608f2ac2a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 20 '22 21:09 sagemaker-bot

Codecov Report

Merging #3363 (6754ef9) into master (ace07d7) will decrease coverage by 0.86%. The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #3363      +/-   ##
==========================================
- Coverage   90.02%   89.15%   -0.87%     
==========================================
  Files         868      204     -664     
  Lines       76852    18983   -57869     
==========================================
- Hits        69185    16925   -52260     
+ Misses       7667     2058    -5609     
Impacted Files Coverage Δ
src/sagemaker/session.py 71.52% <40.00%> (ø)
...b/python3.8/site-packages/sagemaker/local/image.py
.../site-packages/sagemaker/model_monitor/__init__.py
...on3.8/site-packages/sagemaker/debugger/__init__.py
...thon3.9/site-packages/sagemaker/apiutils/_utils.py
...agemaker/async_inference/async_inference_config.py
...te-packages/sagemaker/dataset_definition/inputs.py
...-packages/sagemaker/dataset_definition/__init__.py
...n3.9/site-packages/sagemaker/workflow/utilities.py
...agemaker/serverless/serverless_inference_config.py
... and 1063 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 20 '22 21:09 codecov-commenter

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6754ef9910294cf5fdb7787cfeb384608f2ac2a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 20 '22 21:09 sagemaker-bot

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6754ef9910294cf5fdb7787cfeb384608f2ac2a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot avatar Sep 20 '22 22:09 sagemaker-bot

Merging with override as airflow test failure is unrelated and intermittent.

shreyapandit avatar Sep 22 '22 20:09 shreyapandit