[DRAFT: Do not merge] feature: enable SMDDP for Pytorch DDP distribution

Open vishwakaria opened this issue 1 year ago • 16 comments

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
[x] I used the commit message format described in CONTRIBUTING
[ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)
[ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sep 11 '22 23:09 vishwakaria

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6247fedf4f524a8aa70ce24fc7c0dbb46938d189
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 11 '22 23:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6247fedf4f524a8aa70ce24fc7c0dbb46938d189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 11 '22 23:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6247fedf4f524a8aa70ce24fc7c0dbb46938d189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 12 '22 00:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6247fedf4f524a8aa70ce24fc7c0dbb46938d189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 12 '22 00:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6247fedf4f524a8aa70ce24fc7c0dbb46938d189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 12 '22 00:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c0ca4180518e6ea0b4d34dd6ef7dc067cb342888
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 12 '22 20:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c0ca4180518e6ea0b4d34dd6ef7dc067cb342888
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 12 '22 20:09 sagemaker-bot

Codecov Report

Merging #3355 (e69538d) into master (fe604ff) will decrease coverage by 0.83%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3355      +/-   ##
==========================================
- Coverage   90.02%   89.18%   -0.84%     
==========================================
  Files         868      204     -664     
  Lines       76828    19004   -57824     
==========================================
- Hits        69161    16949   -52212     
+ Misses       7667     2055    -5612

Impacted Files	Coverage Δ
src/sagemaker/fw_utils.py	`91.76% <100.00%> (ø)`
src/sagemaker/pytorch/estimator.py	`100.00% <100.00%> (ø)`
...9/site-packages/sagemaker/drift_check_baselines.py
...hon3.8/site-packages/sagemaker/lineage/__init__.py
...-packages/sagemaker/debugger/profiler_constants.py
...s/sagemaker/tensorflow/training_compiler/config.py
...ackages/sagemaker/async_inference/waiter_config.py
.../python3.9/site-packages/sagemaker/rl/estimator.py
...ges/sagemaker/model_monitor/data_capture_config.py
.../sagemaker/huggingface/training_compiler/config.py
... and 1064 more