fix: StepTypeEnum couldn't be instantiated correctly

Open navaj0 opened this issue 1 year ago • 20 comments

Issue #, if available:

#3272

Description of changes:

The DefaultEnumMeta metaclass is malfunctioned. Enum types defined with this couldn't be instantiated correctly. For example, StepTypeEnum('Processing') leads to StepTypeEnum.CONDITION

Removed this metaclass altogether instead of fixing it because the target behavior "defaulting to the first value in the Enum list" is not particularly useful in the pipeline SDK implementation and can be misleading even implemented correctly.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
[x] I used the commit message format described in CONTRIBUTING
[x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)
[x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sep 02 '22 21:09 navaj0

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0aee8797b8153232b3da8d8ade7d1d85624cc73f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 02 '22 21:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0aee8797b8153232b3da8d8ade7d1d85624cc73f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 02 '22 21:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0aee8797b8153232b3da8d8ade7d1d85624cc73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 02 '22 22:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0aee8797b8153232b3da8d8ade7d1d85624cc73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 02 '22 22:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0aee8797b8153232b3da8d8ade7d1d85624cc73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 02 '22 22:09 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 73163ce668d30266ca01f8a875a4e8dd9091db80
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sep 03 '22 00:09 sagemaker-bot

Codecov Report

Merging #3345 (73163ce) into master (3b45257) will decrease coverage by 0.85%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
- Coverage   90.02%   89.16%   -0.86%     
==========================================
  Files         868      204     -664     
  Lines       76828    18963   -57865     
==========================================
- Hits        69161    16909   -52252     
+ Misses       7667     2054    -5613

Impacted Files	Coverage Δ
src/sagemaker/workflow/entities.py	`100.00% <ø> (ø)`
src/sagemaker/workflow/callback_step.py	`92.15% <100.00%> (ø)`
src/sagemaker/workflow/conditions.py	`78.57% <100.00%> (ø)`
src/sagemaker/workflow/lambda_step.py	`94.82% <100.00%> (ø)`
src/sagemaker/workflow/parameters.py	`93.54% <100.00%> (ø)`
src/sagemaker/workflow/retry.py	`91.25% <100.00%> (ø)`
src/sagemaker/workflow/steps.py	`95.12% <100.00%> (ø)`
...on3.10/site-packages/sagemaker/pytorch/defaults.py
...n3.8/site-packages/sagemaker/xgboost/processing.py
...es/sagemaker/cli/compatibility/v2/modifiers/tfs.py
... and 1069 more