change: Implement test mechanism for Pipeline variables

Open qidewenwhen opened this issue 2 years ago • 59 comments

Description of changes: Implement test mechanism for Pipeline variables to check if they are compatible with downstream classes

Testing done: N/A

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
[x] I used the commit message format described in CONTRIBUTING
[x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)
[x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Jun 07 '22 19:06 qidewenwhen

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: be86fae491c89efca68407a96b587d68e04bd3c6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Jun 07 '22 20:06 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: be86fae491c89efca68407a96b587d68e04bd3c6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Jun 07 '22 20:06 sagemaker-bot

Codecov Report

Merging #3163 (46bba68) into master (bbb715d) will decrease coverage by 0.58%. The diff coverage is 97.10%.

@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
- Coverage   89.83%   89.25%   -0.59%     
==========================================
  Files         645      203     -442     
  Lines       55560    18383   -37177     
==========================================
- Hits        49913    16407   -33506     
+ Misses       5647     1976    -3671

Impacted Files	Coverage Δ
src/sagemaker/amazon/hyperparameter.py	`95.91% <ø> (ø)`
src/sagemaker/processing.py	`94.27% <ø> (ø)`
...agemaker/serverless/serverless_inference_config.py	`100.00% <ø> (ø)`
src/sagemaker/utils.py	`93.14% <ø> (ø)`
src/sagemaker/fw_utils.py	`90.80% <50.00%> (ø)`
src/sagemaker/sklearn/estimator.py	`96.87% <71.42%> (ø)`
src/sagemaker/tensorflow/estimator.py	`93.75% <75.00%> (ø)`
src/sagemaker/training_compiler/config.py	`82.22% <83.33%> (ø)`
src/sagemaker/estimator.py	`90.28% <85.71%> (ø)`
src/sagemaker/amazon/amazon_estimator.py	`88.07% <87.50%> (ø)`
... and 883 more