Fs mutable param search

Open mizanfiu opened this issue 2 years ago • 26 comments

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
[x] I used the commit message format described in CONTRIBUTING
[x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)
[x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

May 18 '22 01:05 mizanfiu

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ff72a63a62155a68bcba397bd45ce0214ec77d4d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 01:05 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ff72a63a62155a68bcba397bd45ce0214ec77d4d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 01:05 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ff72a63a62155a68bcba397bd45ce0214ec77d4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 02:05 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ff72a63a62155a68bcba397bd45ce0214ec77d4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 02:05 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ff72a63a62155a68bcba397bd45ce0214ec77d4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 02:05 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f77bd64f0c5743601c38e108146f740f9c49e600
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 20:05 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f77bd64f0c5743601c38e108146f740f9c49e600
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 20:05 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f77bd64f0c5743601c38e108146f740f9c49e600
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

May 18 '22 20:05 sagemaker-bot

Codecov Report

Merging #3117 (c3b8495) into master (0bb007c) will decrease coverage by 0.60%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3117      +/-   ##
==========================================
- Coverage   89.40%   88.79%   -0.61%     
==========================================
  Files         844      202     -642     
  Lines       71930    17847   -54083     
==========================================
- Hits        64308    15848   -48460     
+ Misses       7622     1999    -5623

Impacted Files	Coverage Δ
src/sagemaker/feature_store/feature_group.py	`76.52% <100.00%> (+0.68%)`	:arrow_up:
src/sagemaker/feature_store/inputs.py	`98.33% <100.00%> (+0.18%)`	:arrow_up:
src/sagemaker/session.py	`71.24% <100.00%> (+0.28%)`	:arrow_up:
...b/python3.9/site-packages/sagemaker/local/image.py
...9/site-packages/sagemaker/environment_variables.py
...-packages/sagemaker/workflow/parallelism_config.py
....7/site-packages/sagemaker/feature_store/inputs.py
...ackages/sagemaker/amazon/factorization_machines.py
.../python3.9/site-packages/sagemaker/deprecations.py
...8/lib/python3.8/site-packages/sagemaker/session.py
... and 635 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0bb007c...c3b8495. Read the comment docs.