change: update modelparallel config validation

Open karakusc opened this issue 2 years ago • 13 comments

Issue #, if available:

Description of changes: Updating the config validation for the modelparallel library, based on the latest release.

Testing done: Ran GPT-2 example script with the updated SageMaker Python SDK.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
[x] I used the commit message format described in CONTRIBUTING
[x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)
[ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Apr 05 '22 19:04 karakusc

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 532fa79988c2c533b81ff311338840158964351f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Apr 05 '22 20:04 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 532fa79988c2c533b81ff311338840158964351f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Apr 05 '22 21:04 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0768fdba877481d322202add0111f72f6dd08351
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Apr 08 '22 23:04 sagemaker-bot

Codecov Report

Merging #3048 (2e4513e) into master (1fa2377) will decrease coverage by 0.26%. The diff coverage is 82.25%.

@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
- Coverage   89.17%   88.91%   -0.26%     
==========================================
  Files         204      206       +2     
  Lines       18979    19183     +204     
==========================================
+ Hits        16924    17057     +133     
- Misses       2055     2126      +71

Impacted Files	Coverage Δ
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	:arrow_down:
...sagemaker/workflow/monitor_batch_transform_step.py	`0.00% <0.00%> (ø)`
src/sagemaker/workflow/utilities.py	`94.31% <ø> (ø)`
src/sagemaker/xgboost/model.py	`96.36% <ø> (-1.82%)`	:arrow_down:
src/sagemaker/session.py	`71.41% <28.57%> (-0.25%)`	:arrow_down:
src/sagemaker/training_compiler/config.py	`80.43% <60.00%> (-2.90%)`	:arrow_down:
src/sagemaker/sklearn/estimator.py	`93.93% <63.63%> (-6.07%)`	:arrow_down:
src/sagemaker/estimator.py	`89.43% <71.42%> (-0.08%)`	:arrow_down:
src/sagemaker/mp_config.py	`80.92% <80.92%> (ø)`
src/sagemaker/amazon/amazon_estimator.py	`87.82% <81.25%> (-0.62%)`	:arrow_down:
... and 22 more