Fix for #2949.

Open osdf opened this issue 2 years ago • 30 comments

Extend the set of types that are not handled by json.dumps to elementary types.

*Issue #2949

Description of changes:

Testing done: Local test.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[ ] I have read the CONTRIBUTING doc
[ ] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
[ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Feb 23 '22 02:02 osdf

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 88ac6c69d732ee32ee381386acdad1166be5d086
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 02:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dbdf1063d134dfeeed440ddf9fe64df3aba55f18
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 02:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dbdf1063d134dfeeed440ddf9fe64df3aba55f18
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 02:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 88ac6c69d732ee32ee381386acdad1166be5d086
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 02:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dbdf1063d134dfeeed440ddf9fe64df3aba55f18
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 03:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 88ac6c69d732ee32ee381386acdad1166be5d086
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 03:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c894434a7c4528757c3c9348701c80f18af734f7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 05:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a82cb7a80af8440c6158bde50b37fc42d1d67d12
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 05:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c894434a7c4528757c3c9348701c80f18af734f7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 06:02 sagemaker-bot

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a82cb7a80af8440c6158bde50b37fc42d1d67d12
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Feb 23 '22 06:02 sagemaker-bot

Codecov Report

Merging #2951 (13223ba) into master (a387c4c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2951   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         196      196           
  Lines       16610    16610           
=======================================
  Hits        14933    14933           
  Misses       1677     1677

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`91.32% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a387c4c...13223ba. Read the comment docs.