SparkMLModel/PipelineModel not supported through LocalSession

[njgerner]

Describe the bug I am unable to run a SparkMLModel via PipelineModel in local mode due to a lack of support for Containers in the LocalSession method create_model.

To reproduce

import boto3
from sagemaker import LocalSession
from sagemaker.pipeline import PipelineModel
from sagemaker.sparkml.model import SparkMLModel

session = LocalSession(boto3.Session(region_name='us-east-1'))

sparkml_model = SparkMLModel(model_data=</path/to/model>, sagemaker_session=session)

sm_model = PipelineModel(
        name="spark-pipeline-model"
        role="arn:aws:iam::<account_id>:role/role-name",
        models=[sparkml_model],
        sagemaker_session=session
)

transformer = sm_model.transformer(
        instance_count=1,
        instance_type="local",
        output_path="path/to/output",
        accept="text/csv",
        assemble_with='Line',
        env={"SAGEMAKER_SPARKML_SCHEMA": SPARK_ML_SCHEMA}
)

Will give the error result below.

Expected behavior LocalSession should support the Containers parameter.

Screenshots or logs

    def create_model(
        self,
        name,
        role,
        container_defs,
        vpc_config=None,
        enable_network_isolation=False,
        primary_container=None,
        tags=None,
    ):
        """Create an Amazon SageMaker ``Model``.
        Specify the S3 location of the model artifacts and Docker image containing
        the inference code. Amazon SageMaker uses this information to deploy the
        model in Amazon SageMaker. This method can also be used to create a Model for an Inference
        Pipeline if you pass the list of container definitions through the containers parameter.
    
        Args:
            name (str): Name of the Amazon SageMaker ``Model`` to create.
            role (str): An AWS IAM role (either name or full ARN). The Amazon SageMaker training
                jobs and APIs that create Amazon SageMaker endpoints use this role to access
                training data and model artifacts. You must grant sufficient permissions to this
                role.
            container_defs (list[dict[str, str]] or [dict[str, str]]): A single container
                definition or a list of container definitions which will be invoked sequentially
                while performing the prediction. If the list contains only one container, then
                it'll be passed to SageMaker Hosting as the ``PrimaryContainer`` and otherwise,
                it'll be passed as ``Containers``.You can also specify the  return value of
                ``sagemaker.get_container_def()`` or ``sagemaker.pipeline_container_def()``,
                which will used to create more advanced container configurations, including model
                containers which need artifacts from S3.
            vpc_config (dict[str, list[str]]): The VpcConfig set on the model (default: None)
                * 'Subnets' (list[str]): List of subnet ids.
                * 'SecurityGroupIds' (list[str]): List of security group ids.
            enable_network_isolation (bool): Wether the model requires network isolation or not.
            primary_container (str or dict[str, str]): Docker image which defines the inference
                code. You can also specify the return value of ``sagemaker.container_def()``,
                which is used to create more advanced container configurations, including model
                containers which need artifacts from S3. This field is deprecated, please use
                container_defs instead.
            tags(List[dict[str, str]]): Optional. The list of tags to add to the model.
    
        Example:
            >>> tags = [{'Key': 'tagname', 'Value': 'tagvalue'}]
            For more information about tags, see https://boto3.amazonaws.com/v1/documentation\
            /api/latest/reference/services/sagemaker.html#SageMaker.Client.add_tags
    
    
        Returns:
            str: Name of the Amazon SageMaker ``Model`` created.
        """
        if container_defs and primary_container:
            raise ValueError("Both container_defs and primary_container can not be passed as input")
    
        if primary_container:
            msg = (
                "primary_container is going to be deprecated in a future release. Please use "
                "container_defs instead."
            )
            warnings.warn(msg, DeprecationWarning)
            container_defs = primary_container
    
        role = self.expand_role(role)
    
        if isinstance(container_defs, list):
            container_definition = container_defs
        else:
            container_definition = _expand_container_def(container_defs)
    
        create_model_request = _create_model_request(
            name=name, role=role, container_def=container_definition, tags=tags
        )
    
        if vpc_config:
            create_model_request["VpcConfig"] = vpc_config
    
        if enable_network_isolation:
            create_model_request["EnableNetworkIsolation"] = True
    
        LOGGER.info("Creating model with name: %s", name)
        LOGGER.debug("CreateModel request: %s", json.dumps(create_model_request, indent=4))
    
        try:
>           self.sagemaker_client.create_model(**create_model_request)
E           TypeError: create_model() missing 1 required positional argument: 'PrimaryContainer'

System information A description of your system. Please provide:

• SageMaker Python SDK version: 2.4.0
• Framework name (eg. PyTorch) or algorithm (eg. KMeans): PySpark
• Framework version: 2.4.6
• Python version: 3.7.0
• CPU or GPU: CPU
• Custom Docker image (Y/N): N uses SparkML Serving - https://sagemaker.readthedocs.io/en/stable/frameworks/sparkml/sagemaker.sparkml.html

Additional context This works as expected not on my local machine, but is necessary for us for automated testing in CI.

[jasonmazursky]

I am also experiencing this issue

[ajaykarpur]

@njgerner, thanks for bringing this to our attention. We'll look into this.

This works as expected not on my local machine, but is necessary for us for automated testing in CI.

Just to make sure I understand your use case: you're using Local Mode just for the purpose of automated testing?

[njgerner]

@njgerner, thanks for bringing this to our attention. We'll look into this.

This works as expected not on my local machine, but is necessary for us for automated testing in CI.

Just to make sure I understand your use case: you're using Local Mode just for the purpose of automated testing?

Correct

[marcelgwerder]

I'm trying to test my pipeline in local mode and I'm running into the same issue. This should be labeled as a bug instead of a feature request as local mode is clearly not working properly. Local mode is a crucial feature because having to wait for instances to spin up remotely is just not an option during development and testing.

import sagemaker
from sagemaker.pytorch.model import PyTorchModel
from sagemaker.pipeline import PipelineModel
from sagemaker import get_execution_role

role = get_execution_role()

session = sagemaker.LocalSession()
session.config = {"local": {"local_code": True}}

pytorch_model = PyTorchModel(
    model_data="./model.tar.gz",
    framework_version="1.5.0",
    code_location="s3://whatever/sagemaker-code",
    sagemaker_session=session,
    py_version="py3",
    role=role, 
    entry_point='inference.py'
)

postproc_model = PyTorchModel(
    model_data="./model.tar.gz",
    framework_version="1.5.0",
    code_location="s3://whatever/sagemaker-code",
    sagemaker_session=session,
    py_version="py3",
    role=role, 
    entry_point='postproc.py'
)

pipeline_model = PipelineModel(
    name="whatever", 
    role=role,
    sagemaker_session=session,
    models=[
        pytorch_model, 
        postproc_model
    ]
)

predictor = pipeline_model.deploy(
    instance_type='local', 
    initial_instance_count=1, 
    wait=False, 
    serializer=sagemaker.serializers.JSONSerializer(),
    deserializer=sagemaker.deserializers.JSONDeserializer()
)

Error:

INFO:sagemaker:Creating model with name: whatever
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-8-1d360bc14bee> in <module>
      4     wait=False,
      5     serializer=sagemaker.serializers.JSONSerializer(),
----> 6     deserializer=sagemaker.deserializers.JSONDeserializer()
      7 )

~/anaconda3/envs/onmt/lib/python3.6/site-packages/sagemaker/pipeline.py in deploy(self, initial_instance_count, instance_type, serializer, deserializer, endpoint_name, tags, wait, update_endpoint, data_capture_config)
    150         self.name = self.name or name_from_image(containers[0]["Image"])
    151         self.sagemaker_session.create_model(
--> 152             self.name, self.role, containers, vpc_config=self.vpc_config
    153         )
    154 

~/anaconda3/envs/onmt/lib/python3.6/site-packages/sagemaker/session.py in create_model(self, name, role, container_defs, vpc_config, enable_network_isolation, primary_container, tags)
   2142 
   2143         try:
-> 2144             self.sagemaker_client.create_model(**create_model_request)
   2145         except ClientError as e:
   2146             error_code = e.response["Error"]["Code"]

TypeError: create_model() missing 1 required positional argument: 'PrimaryContainer'

[atakanguney]

I am also having this issue! Is there any update?

[svpino]

This is a critical problem with Local Mode. Without fixing this, we can't test a pipeline locally.

[liujiaorr]

Does the issue still exist?