s2n-tls icon indicating copy to clipboard operation
s2n-tls copied to clipboard

Add renegotiate apache test to nix/uv/pytest

Open dougch opened this issue 7 months ago • 0 comments

Release Summary:

Resolved issues:

partial for https://github.com/aws/s2n-tls/issues/5040

Description of changes:

Start apache2 with the uvinteg bash function, allowing this test to pass with nix+uv+pytest.

Call-outs:

This adds a cleanup routine for apache2 configs, so when doing local runs of the integration tests, the apache2 configs get regenerated. This is not needed in CI, as we're throwing away Docker containers after the test runs.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Local, CI. How can you convince your reviewers that this PR is safe and effective? Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

Remember:

  • Any change to the library source code should at least include unit tests.
  • Any change to the core stuffer or blob methods should include CBMC proofs.
  • Any change to the CI or tests should:
    1. prove that the test succeeds for good input
    2. prove that the test fails for bad input (eg, a test for memory leaks fails when a memory leak is committed)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dougch avatar Jun 10 '25 18:06 dougch