s2n-tls icon indicating copy to clipboard operation
s2n-tls copied to clipboard

Published 20 hours ago • verified publisher icon aws

-Wcast-qual not enabled in cmake file

Open boquan-fang opened this issue 6 months ago • 3 comments

Problem:

  1. -Wcast-qual is not enabled with awslc.
  2. The S2N_LIBCRYPTO environmental variable needs to be set for that -Wcast-qual to be enabled. https://github.com/aws/s2n-tls/blob/45bf1d4bc314cf8b18b8632e8be25180e45f121f/CMakeLists.txt#L212-L215

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

  • -Wcast-qual should be enabled even if no environmental variables are set.
  • -Wcast-qual should be enabled for awslc.

boquan-fang avatar Aug 15 '24 23:08 boquan-fang