s2n-tls icon indicating copy to clipboard operation
s2n-tls copied to clipboard

Configure duvet to avoid downloading RFC spec files in CI

Open toidiu opened this issue 2 years ago • 2 comments

Problem:

Currently the duvet report command run from the project source dir but the RFC spec files are located in the compliance folder. Since duvet only looks at the current dir when searching for RFC spec files, it needs to download them again. We should fix duvet or how we call it to avoid re-downloading the RFC specs again.

The point of downloading the spec files compliance/specs is to avoid network calls to download them again each time. This is important for CI to be less flaky.

Solution:

  • Add a param to duvet report to specify location of the spec files
  • Move specs to the project root folder (not recommended)

Requirements / Acceptance Criteria:

Calling compliance/generate_report.sh should work without internet connection (test by turning off all internet connection).

toidiu avatar Sep 21 '23 23:09 toidiu

https://github.com/aws/s2n-tls/issues/4219 represents a super rough draft which I used to test and debug the behavior.

toidiu avatar Sep 21 '23 23:09 toidiu

Duvet now supports specifying a different spec file location. Next steps: we need a duvet release before using the new commands.

toidiu avatar Sep 27 '23 22:09 toidiu

Done in https://github.com/aws/s2n-tls/pull/4588

WesleyRosenblum avatar Jun 20 '24 16:06 WesleyRosenblum