porting-assistant-dotnet-ui icon indicating copy to clipboard operation
porting-assistant-dotnet-ui copied to clipboard

feat: update path too long error flash bar

Open JiayuW2 opened this issue 1 year ago • 0 comments

Issue #, if available: Follow up for this https://github.com/aws/porting-assistant-dotnet-ui/pull/620 To add proper alerting message in UI for path too long.

Description of changes: Screen Shot 2022-11-02 at 8 06 57 PM

  1. C# - CopyDirectory will return <Boolean, String> where String will be error message when exception happened
  2. Add error flash bar in UI for the case FilePath + Destination Path > 260, see screen shot above

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

JiayuW2 avatar Nov 04 '22 05:11 JiayuW2