porting-assistant-dotnet-ui icon indicating copy to clipboard operation
porting-assistant-dotnet-ui copied to clipboard

fix: update telemetry

Open kanikaul-amazon opened this issue 3 years ago • 3 comments

Issue #, if available:

Description of changes:

  • Updated telemetry to write to files in telemetry-logs directory instead of buffer.
  • Create PortingAssistant.Telemetry Project to watch telemetry-logs and Post to telemetry endpoint.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kanikaul-amazon avatar Mar 02 '21 17:03 kanikaul-amazon

AWS CodeBuild CI Report

  • CodeBuild project: PortingAssistantBuild-dev
  • Commit ID: 7d4bb500f291a3178e89a57e0defeeb80a4ba383
  • Result: FAILED
  • Build Logs (available for 90 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Except the code comments here, I have an overview question. it looks like we depend on the log file which log system writes. Then I believe we should have a corresponding change for chunk one single big log into several small pieces. could please paste link to that code review here too. Another question is how we handle the metrics stuff.

flywanli avatar Mar 02 '21 20:03 flywanli

AWS CodeBuild CI Report

  • CodeBuild project: PortingAssistantBuild-dev
  • Commit ID: 7d4bb500f291a3178e89a57e0defeeb80a4ba383
  • Result: SUCCEEDED
  • Build Logs (available for 90 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository