porting-assistant-dotnet-ui icon indicating copy to clipboard operation
porting-assistant-dotnet-ui copied to clipboard

feat: Download and package PortingAssistant.Client.CLI.exe in standal…

Open ShanshanHe opened this issue 2 years ago • 1 comments

…one tool.

Issue #, if available:

Description of changes: porting-assistant-dotnet-client github workflow publishes and uploads PortingAssistant.Client.CLI.exe to a public S3 bucket. This patch downloads PortingAssistant.Client.CLI.exe from that S3 bucket and packages it in Porting Assistant standalone tool executable.

Testing done: Manually tested it by running npm run build on the following two systems:

  1. MacOS Catalina
  2. Windows 10 64bit And verify PortingAssistant.Client.CLI.exe exists under porting-assistant-dotnet-ui/packages/electron/netcore_build directory.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ShanshanHe avatar Sep 08 '21 20:09 ShanshanHe

AWS CodeBuild CI Report

  • CodeBuild project: PortingAssistantBuild-dev
  • Commit ID: b08aa32c37e732b171d0436329986dc35b40bfc2
  • Result: FAILED
  • Build Logs (available for 90 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository