pg_tle icon indicating copy to clipboard operation
pg_tle copied to clipboard

Add author attribution to ndistinct README

Open samimseih opened this issue 1 year ago • 4 comments

Description of changes: Adding missing attribution to the ndistinct README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

samimseih avatar Jan 12 '24 21:01 samimseih

Have we done this for other examples?

jkatz avatar Jan 12 '24 21:01 jkatz

We haven't -- it's not too relevant for our existing examples since to my knowledge they weren't proposed or discussed elsewhere first (though I could be wrong about uuid_v7).

adamguo0 avatar Jan 12 '24 21:01 adamguo0

If we go this route, I think for UUIDv7 we should reference the upstream PostgreSQL thread as this predates the implementation and did inspire our discussion around adding it: https://www.postgresql.org/message-id/CAAhFRxitJv%3DyoGnXUgeLB_O%2BM7J2BJAmb5jqAT9gZ3bij3uLDA%40mail.gmail.com

jkatz avatar Jan 12 '24 22:01 jkatz

Makes sense, I can add that to this PR

adamguo0 avatar Jan 12 '24 23:01 adamguo0