karpenter-provider-aws icon indicating copy to clipboard operation
karpenter-provider-aws copied to clipboard

Properly calculate hash of EC2NodeClass for ISO regions

Open amdonov opened this issue 5 months ago • 1 comments

Fixes #7081

Description

In ISO regions the httpProtocolIPv6 feature is not supported. The current code correctly handles this by setting HTTPProtocolIPv6 to nil in unsupported regions. However, the EC2NodeClass spec still contains the default value for HTTPProtocolIPv6 (which is "disabled"). When the hash is calculated, it includes the entire Spec which has HTTPProtocolIPv6: "disabled". But when the launch template is created, HTTPProtocolIPv6 is set to nil (omitted). This creates a mismatch between what's in the NodeClass hash and what's actually deployed. This code properly sets the hash value for the NodeClass.

How was this change tested?

Unit tests

Does this change impact docs?

  • [x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

amdonov avatar Nov 06 '25 17:11 amdonov

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit 627790323c4daf0a89bea9f3cc5d1d9ac9b4bd03
Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/690cdb4c3b414f0008d88f21

netlify[bot] avatar Nov 06 '25 17:11 netlify[bot]