karpenter-provider-aws icon indicating copy to clipboard operation
karpenter-provider-aws copied to clipboard

allow opting in to open capacity reservation matching

Open grosser opened this issue 3 months ago • 3 comments

Fixes https://github.com/aws/karpenter-provider-aws/issues/8176

Description

normally when turning on the capacity reservation feature suddenly all open reservations can no longer match karpenter nodes this change allows restoring that behavior, so everything keeps working and selected nodepools can use targeted capacity reservations if they want

How was this change tested?

bring up instance with label set and see if it matches an open reservation that it did not target via capacityReservationSelectorTerms

Does this change impact docs?

  • [ ] Yes, PR includes docs updates
  • [ ] Yes, issue opened: #
  • [x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

grosser avatar Sep 12 '25 21:09 grosser

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit 20d6a292808947f90a8d89d06c1d72e023433329
Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68c48cdbf744aa000773df6a

netlify[bot] avatar Sep 12 '25 21:09 netlify[bot]

Hey @grosser, I just wanted to draw your attention to this comment I left on the original issue: https://github.com/aws/karpenter-provider-aws/issues/8176#issuecomment-3293246030. Before we go this route and add a "backdoor" to use open-capacity matching, we'd want to have a stronger understanding of the use-case, why it can't be supported by our native mechanism, and what potential changes we could make to that mechanism to address that. Like I said in that comment, if there are use-cases it would be good to document them in a new issue. While I won't say we wouldn't accept this kind of change, I want to make sure we evaluate all of our options first before adding a backdoor.

jmdeal avatar Sep 15 '25 17:09 jmdeal

https://github.com/aws/karpenter-provider-aws/issues/8510

grosser avatar Sep 19 '25 04:09 grosser