karpenter-provider-aws icon indicating copy to clipboard operation
karpenter-provider-aws copied to clipboard

Fix outdated comments of hack/docs/*.go

Open guessi opened this issue 5 months ago • 5 comments

Fixes #N/A

Description

The path for the docgen changed, but comments not updated.

How was this change tested?

N/A, it's just comments.

Does this change impact docs?

  • [ ] Yes, PR includes docs updates
  • [ ] Yes, issue opened: #
  • [x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

guessi avatar Jul 03 '25 16:07 guessi

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit 87921acb8e8e49f8802c50d8a4df2c09edec626a
Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/689de0c1433cca000771301b

netlify[bot] avatar Jul 03 '25 16:07 netlify[bot]

I'm not sure if I should touch https://github.com/aws/karpenter-provider-aws/blob/main/tools/kompat/go.mod so I leave it unchanged.

guessi avatar Jul 03 '25 16:07 guessi

Pull Request Test Coverage Report for Build 18340833139

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 67.448%

Files with Coverage Reduction New Missed Lines %
pkg/fake/iamapi.go 5 57.69%
pkg/providers/instanceprofile/instanceprofile.go 8 81.22%
<!-- Total: 13
Totals Coverage Status
Change from base Build 18326599804: -0.1%
Covered Lines: 7768
Relevant Lines: 11517

💛 - Coveralls

coveralls avatar Jul 03 '25 16:07 coveralls

Preview deployment ready!

Preview URL: https://pr-8239.d18coufmbnnaag.amplifyapp.com

Built from commit b15b3434bad7113ec6fa84ce0926552fbbd76133

github-actions[bot] avatar Aug 14 '25 13:08 github-actions[bot]

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit b15b3434bad7113ec6fa84ce0926552fbbd76133
Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68e634bfcbe6f900089df1df

netlify[bot] avatar Oct 08 '25 09:10 netlify[bot]