karpenter-provider-aws
karpenter-provider-aws copied to clipboard
fix: Add missing metrics to docs by setting KARPENTER_CORE_DIR and updating metrics_gen/main.go
PR Description
This PR addresses the issue of missing metrics in the Karpenter documentation by ensuring the KARPENTER_CORE_DIR variable is explicitly set in the docgen.sh script. Additionally, the metrics_gen/main.go file has been updated to accommodate metrics that use the opmetrics function package. The logic has been adjusted to iterate over arguments and find compositeList instead of relying on the first argument being compositeList.
Changes:
Explicitly set KARPENTER_CORE_DIR in docgen.sh to ensure all metrics are generated.
Updated metrics_gen/main.go to handle metrics using opmetrics and improved the logic for processing compositeList.
References:
Related Issue: https://github.com/aws/karpenter-provider-aws/issues/7739
Deploy Preview for karpenter-docs-prod canceled.
| Name | Link |
|---|---|
| Latest commit | 722a2057a35bfbcaaabda6f5b479901bb31ba756 |
| Latest deploy log | https://app.netlify.com/projects/karpenter-docs-prod/deploys/68c5315ac5a4f700086ffb81 |
Hey @jonathan-innis @jigisha620 , a quick reminder about this PR. Thanks in advance!
Hey @engedaam, a quick reminder about this PR. Thanks in advance!