karpenter-provider-aws icon indicating copy to clipboard operation
karpenter-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon aws

[helm chart] Only create ServiceMonitor if CRD/api resource is available

Open asherf opened this issue 1 year ago • 2 comments

Description

It is best practice to make sure a given api resource is defined in the cluster before trying to create it. Example: https://github.com/fluent/helm-charts/blob/154127f95f40ea53f7955826a937340cf2b48dad/charts/fluent-bit/templates/servicemonitor.yaml#L1C1-L1C106

asherf avatar Jul 28 '24 02:07 asherf

Deploy Preview for karpenter-docs-prod canceled.

Name Link
Latest commit 4c538a97fdabfefbbff3436f70fafad05aba8da8
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66cbc46dd955900008e5727e

netlify[bot] avatar Jul 28 '24 02:07 netlify[bot]

@bwagner5 any feedback here ? I'd love if this change can land

asherf avatar Aug 07 '24 19:08 asherf