karpenter-provider-aws icon indicating copy to clipboard operation
karpenter-provider-aws copied to clipboard

no service port 8443 found for service "karpenter" after migrating from cluster autoscaler

Open TimSin opened this issue 1 year ago • 26 comments

Description

Observed Behavior:

After following the instructions https://karpenter.sh/preview/getting-started/migrating-from-cas/, when trying to create the NodePool (as outlined here) I receive the error:

Error from server: error when creating "nodepool.yaml": conversion webhook for karpenter.sh/v1beta1, Kind=NodePool failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": no service port 8443 found for service "karpenter"

Expected Behavior:

A working karpenter installation

Reproduction Steps (Please include YAML):

I followed the instructions at https://karpenter.sh/preview/getting-started/migrating-from-cas/ on an existing EKS cluster.

Versions:

  • Chart Version: 0.37.0
  • Kubernetes Version (kubectl version): 1.30.2

TimSin avatar Jul 18 '24 14:07 TimSin

We have the exact same error. Unable to even remove Karpenter at this point either

rwe-dtroup avatar Jul 18 '24 17:07 rwe-dtroup

The preview section of the Karpenter docs are used upcoming and pre-released version of Karpenter. I suggest you use the latest version of Karpetner which would be v0.37.0. https://karpenter.sh/v0.37. Specifically: https://karpenter.sh/v0.37/getting-started/migrating-from-cas/

engedaam avatar Jul 22 '24 20:07 engedaam

Same problem here.

fnmarquez avatar Jul 23 '24 17:07 fnmarquez

@fnmarquez What is the page are you using?

engedaam avatar Jul 23 '24 18:07 engedaam

EDIT 7/26: We were able to resolve this today, it turned out the main branch CRDs were applied to the cluster instead of the 0.37.0-tagged CRDs. This caused a lot of requirements confusion but once we diff'd what was running in the cluster we were able to track it down based on the v1 configurations.

We hit the same issue when upgrading our existing EKS configurations, there was no previous cluster-autoscaler configuration in use. Using the 0.37 helm chart we have webhook.enabled: false from the default values. These same errors only started showing up in our cluster after upgrading from 0.36.2 to 0.37 and applying the latest CRDs.

>  kubectl get nodeclaim -A
Error from server: conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": no service port 8443 found for service "karpenter"
> kubectl logs deployment/karpenter -n kube-system
{"level":"ERROR","time":"2024-07-24T23:20:37.998Z","logger":"controller","message":"Reconciler error","commit":"490ef94","controller":"provisioner","error":"creating node claim, conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post \"https://karpenter.kube-system.svc:8443/?timeout=30s\": no service port 8443 found for service \"karpenter\"; creating node claim, conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post \"https://karpenter.kube-system.svc:8443/?timeout=30s\": no service port 8443 found for service \"karpenter\"","errorCauses":[{"error":"creating node claim, conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post \"https://karpenter.kube-system.svc:8443/?timeout=30s\": no service port 8443 found for service \"karpenter\""},{"error":"creating node claim, conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post \"https://karpenter.kube-system.svc:8443/?timeout=30s\": no service port 8443 found for service \"karpenter\""}]}
{"level":"ERROR","time":"2024-07-24T23:20:42.036Z","logger":"controller","message":"Reconciler error","commit":"490ef94","controller":"node.termination","controllerGroup":"","controllerKind":"Node","Node":{"name":"ip-1-2-3-4.ec2.internal"},"namespace":"","name":"ip-1-2-3-4.ec2.internal","reconcileID":"<ID>","error":"deleting nodeclaims, conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post \"https://karpenter.kube-system.svc:8443/?timeout=30s\": no service port 8443 found for service \"karpenter\""}

Once I flipped the webhook value to true and added the port configuration to our deployment, we started getting different errors for signed cert trust:

> kubectl get nodeclaim -A
Error from server: conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": tls: failed to verify certificate: x509: certificate signed by unknown authority

Now I'm starting to go down the rabbit-hole of generating a self-signed cert and updating the caBundle base64-encoded PEM cert value in our validation.webhook.karpenter.k8s.aws ValidatingWebhookConfiguration to see if this will get us working again. So far I'm not confident that this is the right approach for resolving this issue but it's put a halt on our Karpenter upgrades until we can find a proper path forward.

NicholasRaymondiSpot avatar Jul 25 '24 17:07 NicholasRaymondiSpot

We are also facing the same issue. Karpenter v0.37.0 was running fine in eks cluster 1.29. Post upgrading the cluster to 1.30, this issue started to occur. We were not using webhooks before too.

> kubectl get service -n kube-system karpenter
NAME        TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
karpenter   ClusterIP   172.20.116.212   <none>        8000/TCP   43s
> kubectl logs -n kube-system -l app.kubernetes.io/name=karpenter
{"level":"ERROR","time":"2024-08-05T06:40:22.229Z","logger":"controller","message":"Reconciler error","commit":"490ef94","controller":"nodeclass.status","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass","EC2NodeClass":{"name":"XXXX-ec2nodeclass"},"namespace":"","name":"XXX-ec2nodeclass","reconcileID":"81bd9baf-5b2d-4f26-af7b-XXXXX","error":"conversion webhook for karpenter.k8s.aws/v1beta1, Kind=EC2NodeClass failed: Post \"https://karpenter.kube-system.svc:8443/?timeout=30s\": no service port 8443 found for service \"karpenter\""}

Checks done:

  1. No webhooks related to Karpenter exists in validatingwebhookconfigurations and mutatingwebhookconfigurations
  2. Pods and Service are running.

Update: It's working now Purged everything related to Karpenter and re-installed. Just worked fine. Still unsure why but I did notice the CRDs were never deleted upon first try of purging -- had to delete manually by removing finaliser.

code-crusher avatar Aug 05 '24 06:08 code-crusher

I installed karpenter in a separate namespace and with a different service name than the default.

I can't configure the values ​​for the webhook and it returns the error:

service: karpenter not found.

However, it is obvious that I did not create the service with this name in the kube-system namespace.

I am using version 0.37.1 and I installed karpenter with ArgoCD.

Vinaum8 avatar Aug 15 '24 20:08 Vinaum8

Ran into similar problems, we solved our problem by not using static CRDs that have hardcoded webhook items enabled. We switched to the karpenter-crd helm chart and updated the webhook values.

See: https://karpenter.sh/preview/upgrading/upgrade-guide/#crd-upgrades

rcalosso avatar Aug 22 '24 00:08 rcalosso

#6818

Vinaum8 avatar Aug 22 '24 20:08 Vinaum8

the simplest way to upgrade the karpenter is to delete all validating and mutatingwebhooks since karpenter .37.0+ does not uses any webhooks kubectl delete validatingwebhookconfiguration validation.webhook.config.karpenter.sh validation.webhook.karpenter.sh kubectl delete mutatingwebhookconfigurations defaulting.webhook.karpenter.k8s.aws

akramincity avatar Sep 04 '24 10:09 akramincity

the simplest way to upgrade the karpenter is to delete all validating and mutatingwebhooks since karpenter .37.0+ does not uses any webhooks kubectl delete validatingwebhookconfiguration validation.webhook.config.karpenter.sh validation.webhook.karpenter.sh kubectl delete mutatingwebhookconfigurations defaulting.webhook.karpenter.k8s.aws

Not the easiest of upgrades if you're doing this through pipelines though. Having the CRD updated/replaced seems to be the better option right now.

The issue we faced was having tried to update to the newer version, you could no longer do anything due to the CRD looking for the mutating webhook, which looks like it's an issue on the listener of the server, where in actual fact it is nothing to do with it and you can end up down a rabbit hole.

rwe-dtroup avatar Sep 04 '24 11:09 rwe-dtroup

we are also facing this same issue after upgrading from 0.32.1 to 0.37.2

We tried deleting the above mentioned webhooks and even tried the helm upgrade flag --reuse-values to try to force the new helm upgrade to not remove the svc port 8443.

While --reuse-values preserves the svc 8443 port it causes other strange side effects where the karpenter clusrterrole does not correctly upgrade with some permissions missing

It's also worth noting that the crd definitions for nodepool and ec2nodeclass also refer to the service in the kube-system namespace despite the v0.32.1 using the karpenter namespace

Would really appreciate a detailed working solution for this upgrade please

gearoidrog avatar Sep 09 '24 13:09 gearoidrog

I am seeing similar issue when I try to Upgrade Karpenter to major version 1.0.0 from v0.36.2 .Karpnter argo sync status is broken but I do see pods running with below errors .

{"level":"ERROR","time":"2024-09-09T01:23:18.867Z","logger":"controller","message":"Reconciler error","commit":"490ef94","controller":"provisioner","error":"creating node claim, conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": service "karpenter" not found"}

{"level":"ERROR","time":"2024-09-09T01:23:19.314Z","logger":"controller","message":"Reconciler error","commit":"490ef94","controller":"nodeclass.hash","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass","EC2NodeClass":{"name":"applications"},"namespace":"","name":"applications","reconcileID":"77f1ac75-ebe2-485f-8758-4e47730b47ac","error":"conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": service "karpenter" not found; conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": service "karpenter" not found","errorCauses":[{"error":"conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": service "karpenter" not found"},{"error":"conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": service "karpenter" not found"}]}

akunduru9 avatar Sep 09 '24 13:09 akunduru9

you need to update the namespace in crd to kube-system

amohamedhey avatar Sep 10 '24 11:09 amohamedhey

As @amohamedhey mentioned, if you have the conversion webhook enabled, you need to change namespace in there:

# ec2nodeclasses.karpenter.k8s.aws
# nodeclaims.karpenter.sh
# nodepools.karpenter.sh 

#...
  conversion:
    strategy: Webhook
    webhook:
      conversionReviewVersions:
        - v1beta1
        - v1
      clientConfig:
        service:
          name: karpenter
          namespace: kube-system
          port: 8443

piximos avatar Sep 10 '24 11:09 piximos

There is an additional detail to the above that is important and causing these issues when using Argocd. And that is the fact that the service definition has the name variablized (https://github.com/aws/karpenter-provider-aws/blob/v0.37.0/charts/karpenter/templates/service.yaml#L4) BUT as shown above WHEN the conversion piece is included in the CRDs the service name is hardcoded (https://github.com/aws/karpenter-provider-aws/blob/v0.36.4/pkg/apis/crds/karpenter.sh_nodeclaims.yaml#L817). Thus when you change the template name in argocd (say when you are deploying to multiple clusters) the service name changes and then everything breaks due to the hardcoded crd name.

The same issue also exists for namespaces changes.

I am not sure how to bring this to the attention of the devs. Probably the easiest fix for this would be to not variablize the name of the k8s service for kapenter.

scotthesterberg avatar Sep 10 '24 19:09 scotthesterberg

Fix for the above is to add the below var to your vars file:

fullnameOverride: karpenter

scotthesterberg avatar Sep 11 '24 18:09 scotthesterberg

It's happend me after move from 0.37 to 1.0.1

davidt-gh avatar Sep 12 '24 12:09 davidt-gh

2 things that fixed it for me were

  1. pass this flag in the helm upgrade command --set webhook.enabled=true
  2. after downloading the CRD files for nodepool, ec2nodeclass and nodeclaims run a yq update to change the namespace to karpenter and then apply the updated yaml files yq eval '.spec.conversion.webhook.clientConfig.service.namespace = "karpenter"'

gearoidrog avatar Sep 12 '24 13:09 gearoidrog

2 things that fixed it for me were

  1. pass this flag in the helm upgrade command --set webhook.enabled=true
  2. after downloading the CRD files for nodepool, ec2nodeclass and nodeclaims run a yq update to change the namespace to karpenter and then apply the updated yaml files yq eval '.spec.conversion.webhook.clientConfig.service.namespace = "karpenter"'

What version do you use? did you upgraded to 1.x?

davidt-gh avatar Sep 15 '24 05:09 davidt-gh

Didn't run into any of these issues when upgraded from 0.37.2-> 0.37.3 first before migrating to v1.0.0. We also got on to the latest patch version 1.0.2 as well.

sudeepthisingi avatar Sep 18 '24 21:09 sudeepthisingi

@pheianox @amohamedhey @sudeepthisingi

I tried updating my version from 36.2 to 1.0.1, and I’m seeing the following error. Do we need to install the webhooks manually? Below are the errors I’m encountering:

{"level":"INFO","time":"2024-09-23T17:55:24.495Z","logger":"controller","message":"k8s.io/[email protected]/tools/cache/reflector.go:232: failed to list *v1.ConfigMap: Unauthorized","commit":"490ef94"} {"level":"ERROR","time":"2024-09-23T17:55:24.495Z","logger":"controller","message":"k8s.io/[email protected]/tools/cache/reflector.go:232: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: Unauthorized","commit":"490ef94"} I have a ClusterRole with the necessary permissions, but we're still seeing the error. Here is my ClusterRole:

❯ kubectl get clusterrole karpenter -o yaml

apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: creationTimestamp: "2024-09-23T17:43:52Z" labels: app.kubernetes.io/instance: karpenter app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: karpenter app.kubernetes.io/version: 0.37.0 argocd.argoproj.io/instance: eco-sandbox2.karpenter.karpenter helm.sh/chart: karpenter-0.37.0 name: karpenter resourceVersion: "157980964" uid: d256470a-eac6-4b0f-bbba-d97a5b2d5f11 rules:

  • apiGroups:
    • karpenter.k8s.aws resources:
    • ec2nodeclasses verbs:
    • get
    • list
    • watch
  • apiGroups:
    • karpenter.k8s.aws resources:
    • ec2nodeclasses
    • ec2nodeclasses/status verbs:
    • patch
    • update
  • apiGroups:
    • admissionregistration.k8s.io resources:
    • mutatingwebhookconfigurations
    • validatingwebhookconfigurations verbs:
    • get
    • list
    • watch Additionally, here is my conversion configuration in the CRDs:

CRD NAMESPACE CONFIG ; conversion: strategy: Webhook webhook: conversionReviewVersions: - v1beta1 - v1 clientConfig: service: name: karpenter namespace: karpenter port: 8443

akunduru9 avatar Sep 23 '24 18:09 akunduru9

I had the same issue. I solved this by using karpenter-crd chart and changed the serviceNamespace to the namespace that we installed karpenter.

lzyli avatar Sep 24 '24 10:09 lzyli

I was able to get above issue resolved however seeing different issue now any idea on below error ?

name":"applications"},"namespace":"","name":"applications","reconcileID":"97c36b12-0155-416b-8bd1-32e0eca51423","error":"conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": tls: failed to verify certificate: x509: certificate signed by unknown authority; conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": tls: failed to verify certificate: x509: certificate signed by unknown authority","errorCauses":[{"error":"conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": tls: failed to verify certificate: x509: certificate signed by unknown authority"},{"error":"conversion webhook for karpenter.sh/v1beta1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": tls: failed to verify certificate: x509: certificate signed by unknown authority"}]}

akunduru9 avatar Sep 25 '24 15:09 akunduru9

I had the same issue. I solved this by using karpenter-crd chart and changed the serviceNamespace to the namespace that we installed karpenter.

I'm really hard to understand, why they made it default to kube-system? this change is make a lot of mess in here. @avielb-navina @jonathan-innis - I saw this is documented by you guys

davidt-gh avatar Sep 26 '24 04:09 davidt-gh

This issue has been inactive for 14 days. StaleBot will close this stale issue after 14 more days of inactivity.

github-actions[bot] avatar Oct 10 '24 12:10 github-actions[bot]

Ran into same conflict and it broke ArgoCD deployments.

Followed the upgrade instructions from the karpenter documentation Upgraded from 0.34 to 0.34.7

ComparisonError Failed to load live state: failed to get cluster info for "https://k8s-cluster": error synchronizing cache state : failed to sync cluster https://k8s-cluster: failed to load initial state of resource EC2NodeClass.karpenter.k8s.aws: conversion webhook for karpenter.k8s.aws/v1beta1, Kind=EC2NodeClass failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": service "karpenter" not found

nativo-mshivaswamy avatar Oct 16 '24 16:10 nativo-mshivaswamy

@nativo-mshivaswamy Could you please confirm which services are listed when running kubectl get svc? I believe the service running on port 8443 was introduced starting from version 0.36.7.

neike894 avatar Oct 16 '24 16:10 neike894

Fix for the above is to add the below var to your vars file:

fullnameOverride: karpenter

thanks its help me to resolve my problem

neike894 avatar Oct 17 '24 23:10 neike894

Problem still persist if using kustomize and just karpenter chart with symlinked crds

---
apiVersion: source.toolkit.fluxcd.io/v1
kind: HelmRepository
metadata:
  name: karpenter
  namespace: flux-system
spec:
  interval: 17m
  type: oci
  url: oci://public.ecr.aws/karpenter/
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: karpenter
  namespace: karpenter
spec:
  install:
    createNamespace: true
    crds: CreateReplace
  upgrade:
    crds: CreateReplace
  interval: 9m
  chart:
    spec:
      chart: karpenter
      version: 1.0.6
      sourceRef:
        kind: HelmRepository
        name: karpenter
        namespace: flux-system
      interval: 14m
  values:
    priorityClassName: system-cluster-critical
    logLevel: info
    controller:
      resources:
        requests:
          cpu: 0.2
          memory: 768Mi
        limits:
          cpu: 0.2
          memory: 768Mi
    settings:
      clusterName: "${clusterName}"
      defaultInstanceProfile: "KarpenterInstanceProfile-${clusterName}"
      interruptionQueue: "KarpenterInterruptions-${clusterName}"
      featureGates:
        driftEnabled: true
    serviceAccount:
      create: false
      name: karpenter-oidc
    webhook:
      enabled: true
    fullnameOverride: karpenter

All crds after upgrade has 'kube-system' namespace for karpenter service which leads to an error in both kustomizations and pod logs

conversion webhook for karpenter.k8s.aws/v1beta1, Kind=EC2NodeClass failed: Post "https://karpenter.kube-system.svc:8443/?timeout=30s": service "karpenter" not found

rkashasl avatar Oct 31 '24 12:10 rkashasl