jsii icon indicating copy to clipboard operation
jsii copied to clipboard

(aws-quicksight): quicksight generated Python is really huge could it be smaller?

Open jeffb4 opened this issue 1 year ago • 5 comments

Describe the feature

This isn't a bug, but the size of the quicksight Python code is very large and breaks in vscode's default python server

[Error - 10:24:44 PM] (36155) File length of "/home/vscode/.local/lib/python3.8/site-packages/aws_cdk/aws_quicksight/__init__.py" is 72024295 which exceeds the maximum supported file size of 52428800

I confirmed that yeah, that's a beefy boi

-rw-rw-r-- 1 vscode vscode 69M Apr 20 23:08 /home/vscode/.local/lib/python3.8/site-packages/aws_cdk/aws_quicksight/__init__.py

Use Case

I don't think the python language server would be able to by default show typing hints etc for that module, which would be great.

Proposed Solution

I understand the Python is generated with jsii from typescript sources - I don't know if the typescript source file is huge and could be shrunk down, or if the conversion is particularly inefficient.

Other Information

No response

Acknowledgements

  • [ ] I may be able to implement this feature request
  • [ ] This feature might incur a breaking change

CDK version used

aws-cdk-lib 2.73.0

Environment details (OS name and version, etc.)

Linux docker-desktop 5.15.49-linuxkit aws/aws-cdk#1 SMP Tue Sep 13 07:51:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

jeffb4 avatar Apr 21 '23 22:04 jeffb4