jsii icon indicating copy to clipboard operation
jsii copied to clipboard

fix(jsii-diff): renaming a positional argument is a breaking change in Python

Open RomainMuller opened this issue 4 years ago • 4 comments

Related: #2927


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

RomainMuller avatar Aug 04 '21 15:08 RomainMuller

@RomainMuller any progress on this?

gshpychka avatar May 17 '22 09:05 gshpychka

@RomainMuller do you think this has any chance of getting merged? I'm assuming the lack of progress is due to the high number of deprecations required on the CDK side.

gshpychka avatar Sep 16 '22 12:09 gshpychka

@RomainMuller do you think this has any chance of getting merged? I'm assuming the lack of progress is due to the high number of deprecations required on the CDK side.

We are also consider alternate solutions to this...

Quite frankly... it might be "easier" to wait for Python 3.7 EOL next June, as Python 3.8+ supports "positional-only" argument notation (using the / modifier), which we could then adopt and forego this problem entirely.

RomainMuller avatar Sep 19 '22 11:09 RomainMuller

@RomainMuller do you think this has any chance of getting merged? I'm assuming the lack of progress is due to the high number of deprecations required on the CDK side.

We are also consider alternate solutions to this...

Quite frankly... it might be "easier" to wait for Python 3.7 EOL next June, as Python 3.8+ supports "positional-only" argument notation (using the / modifier), which we could then adopt and forego this problem entirely.

Got it. But that would still be a breaking change, some folks may be using them as keyword arguments.

gshpychka avatar Sep 19 '22 11:09 gshpychka

Got it. But that would still be a breaking change, some folks may be using them as keyword arguments.

Yeah... Nothing is ever that easy... we might be able to strategize around this however.

RomainMuller avatar Sep 20 '22 11:09 RomainMuller