eks-distro icon indicating copy to clipboard operation
eks-distro copied to clipboard

Fix broken changelog links in release announcements

Open markapruett opened this issue 2 years ago • 2 comments

The changelog links go to a 404. Correct these to link to the files correctly. Example: https://github.com/aws/eks-distro/releases

Is this because we reuse the same text for the docs site and the release page?

markapruett avatar Sep 16 '22 20:09 markapruett

Hiya. I can work on this, but since it might entail giving me too much access - that's fine if I can't. Links for reference:

https://distro.eks.amazonaws.com/releases/1-23/5/CHANGELOG-v1-23-eks-5 - docs site link

https://github.com/aws/eks-distro/blob/v1-23-eks-5/CHANGELOG-v1-23-eks-5.md - broken link from announcements

https://github.com/aws/eks-distro/blob/main/docs/contents/releases/1-23/5/CHANGELOG-v1-23-eks-5.md - working link

dublinsubway avatar Sep 18 '22 14:09 dublinsubway

Thanks @dublinsubway! You should be able to see everything you need to make these changes in the EKS-D repo.

markapruett avatar Sep 20 '22 19:09 markapruett

We want to remove the For additional information, see the changelog for this release. line from the releases page BUT keep it on the index.md for the release (example)

kschumy avatar Oct 11 '22 19:10 kschumy

@zafs23 @kschumy Can this ticket be closed out?

markapruett avatar Oct 28 '22 15:10 markapruett

After releasing all the github release docs will close this ticket

zafs23 avatar Nov 02 '22 19:11 zafs23