eks-distro-build-tooling
eks-distro-build-tooling copied to clipboard
aws
Backport fix for CVE-2022-2880 to go-1.16.15
Issue #, if available: #500
Description of changes: Backport patch from 1.18 for CVE-2022-2880
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rcrozean by writing /assign @rcrozean in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
hm, the unit test associate with this change is failing
--- FAIL: TestReverseProxyQueryParameterSmugglingDirectorParsesForm (0.00s)
reverseproxy_test.go:1589: proxy forwarded raw query "a=1&a=2;b=3" as "a=1&a=2&b=3", want "a=1"
FAIL
FAIL net/http/httputil 0.817s
@rcrozean: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| golang-1.17-tooling-presubmit | af2ebfa183b0ba034845d2b7648ed270e60fbbba | link | true | /test golang-1.17-tooling-presubmit |
| golang-1.18-tooling-presubmit | af2ebfa183b0ba034845d2b7648ed270e60fbbba | link | true | /test golang-1.18-tooling-presubmit |
| eks-distro-base-tooling-presubmits-python-3.9 | af2ebfa183b0ba034845d2b7648ed270e60fbbba | link | true | /test eks-distro-base-tooling-presubmits-python-3.9 |
| eks-distro-base-tooling-presubmits-python-3.9-2022 | af2ebfa183b0ba034845d2b7648ed270e60fbbba | link | true | /test eks-distro-base-tooling-presubmits-python-3.9-2022 |
| golang-1.19-tooling-presubmit | 22f24bd06376e07ec644701e21b6f5d17aecca76 | link | true | /test golang-1.19-tooling-presubmit |
| golang-1.16-tooling-presubmit | c50317aa0d6a85ec654e0b9719d8427200ffbc2b | link | true | /test golang-1.16-tooling-presubmit |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.