eks-distro-build-tooling icon indicating copy to clipboard operation
eks-distro-build-tooling copied to clipboard

gen-attribution: Handles multi case license file names

Open jaxesn opened this issue 2 years ago • 5 comments

Issue #, if available:

Description of changes:

We finally ran into the first case where a LICENSE file wasnt named upper case in https://github.com/aws/eks-anywhere-build-tooling/pull/1107. The code previously looked for various versions of LICENSE(.md|txt) but still required them to be upper case. This change introduces glob which allows for regex like dir navigating to support any casing of license.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jaxesn avatar Aug 02 '22 21:08 jaxesn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 02 '22 23:08 eks-distro-bot

/retest

abhay-krishna avatar Aug 02 '22 23:08 abhay-krishna

/retest

jaxesn avatar Aug 03 '22 00:08 jaxesn

New changes are detected. LGTM label has been removed.

eks-distro-bot avatar Aug 03 '22 00:08 eks-distro-bot

/retest

markapruett avatar Sep 23 '22 14:09 markapruett

/retest

kschumy avatar Sep 29 '22 21:09 kschumy

@jaxesn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-distro-base-tooling-presubmits-java c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-java
eks-distro-base-tooling-presubmits-java-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-java-2022
eks-distro-base-tooling-presubmits-compiler-base c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-compiler-base
eks-distro-base-tooling-presubmits-compiler-base-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-compiler-base-2022
golang-1.16-tooling-presubmit c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test golang-1.16-tooling-presubmit
golang-1.17-tooling-presubmit c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test golang-1.17-tooling-presubmit
golang-1.18-tooling-presubmit c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test golang-1.18-tooling-presubmit
eks-distro-base-tooling-presubmits-python-3.9 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-python-3.9
eks-distro-base-tooling-presubmits-nodejs-16-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-nodejs-16-2022
eks-distro-base-tooling-presubmits-python-3.9-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-python-3.9-2022
eks-distro-base-tooling-presubmits-golang-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-2022
eks-distro-base-tooling-presubmits-golang c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang
eks-distro-base-tooling-presubmits-nodejs-16 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-nodejs-16
eks-distro-base-make-tests c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-make-tests
eks-distro-base-tooling-presubmits-golang-1-18-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-18-2022
eks-distro-base-tooling-presubmits-golang-1-16-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-16-2022
eks-distro-base-tooling-presubmits-golang-1-19-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-19-2022
eks-distro-base-tooling-presubmits-golang-1-17 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-17
eks-distro-base-tooling-presubmits-golang-1-16 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-16
eks-distro-base-tooling-presubmits-golang-1-15 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-15
eks-distro-base-tooling-presubmits-golang-1-19 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-19
eks-distro-base-tooling-presubmits-golang-1-17-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-17-2022
eks-distro-base-tooling-presubmits-golang-1-18 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-18
eks-distro-base-tooling-presubmits-golang-1-15-2022 c07276d475e7ec5e73f13d0e1bd36e0344bcf674 link true /test eks-distro-base-tooling-presubmits-golang-1-15-2022
builder-base-tooling-presubmit-2022 2b9ac924f18c40eb2aa89bc62f447092f2526a5d link true /test builder-base-tooling-presubmit-2022
builder-base-tooling-presubmit 2b9ac924f18c40eb2aa89bc62f447092f2526a5d link true /test builder-base-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

eks-distro-bot avatar Oct 25 '22 19:10 eks-distro-bot