eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Add missing vSphere E2E tests

Open sp1999 opened this issue 1 year ago • 5 comments

Description of changes:

This PR does the following in the vSphere E2E tests:

  • For packages tests, it adds the missing E2E tests for kubernetes v1.29 as they weren't added when we first started supporting it in #7562.
  • It also updates all the kubernetes v1.27 and v1.29 packages tests to regional curated packages tests as a follow-up to #8569.
  • For all other tests, it adds the missing kubernetes v1.26 and v1.27 tests to cover all scenarios. For tests which have only test for an older kubernetes version, it updates that test to the latest kubernetes v1.30.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sp1999 avatar Aug 22 '24 22:08 sp1999

/cherry-pick release-0.20

sp1999 avatar Aug 22 '24 22:08 sp1999

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Aug 22 '24 22:08 eks-distro-pr-bot

/approve

sp1999 avatar Aug 22 '24 22:08 sp1999

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 22 '24 22:08 eks-distro-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.55%. Comparing base (69c906b) to head (4d415cc). Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8653   +/-   ##
=======================================
  Coverage   73.54%   73.55%           
=======================================
  Files         578      578           
  Lines       36580    36580           
=======================================
+ Hits        26903    26905    +2     
+ Misses       7956     7955    -1     
+ Partials     1721     1720    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 22:08 codecov[bot]

/lgtm

abhay-krishna avatar Sep 04 '24 01:09 abhay-krishna

@sp1999: new pull request created: #8704

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Sep 04 '24 01:09 eks-distro-pr-bot