eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Update skipped tests

Open sp1999 opened this issue 1 year ago • 3 comments

Description of changes:

Commit 1 This commit removes non-existent tests from the SKIPPED_TESTS file. This is because those tests had been removed previously for various reasons. #5799 removed external etcd tests for tinkerbell as external etcd was not supported at the time for kubernetes version v1.27. #7310 removed bottlerocket tests for tinkerbell as bottlerocket is being deprecated for baremetal which included the workload cluster upgrade tests. #7659 temporarily skipped couple of E2E tests which were broken either due to feature changes or env issues which included the TestTinkerbellAirgappedKubernetes129UbuntuProxyConfigFlow test but the latest v1.30 test for this flow has been passing for a while now so it's safe to remove from the SKIPPED_TESTS.

Commit 2 This commit adds more simple flow and upgrade flow tinkerbell tests for kubernetes versions v1.28 and v1.29 to SKIPPED_TESTS as we already skip the tests for those tests for kubernetes versions v1.26 and v1.27. Those tests are passing on the latest kubernetes version v1.30 so it's safe to skip the tests for older versions.

Commit 3 This commit adds v1.31 UpgradeFromLatest tests to SKIPPED_TESTS and updates the outdated tests to the latest kubernetes version v1.30 as these tests won't pass until the new EKS-A release is out with the new kubernetes version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sp1999 avatar Aug 20 '24 07:08 sp1999

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.53%. Comparing base (7053c7e) to head (8346002). Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8643   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files         578      578           
  Lines       36557    36557           
=======================================
  Hits        26882    26882           
  Misses       7955     7955           
  Partials     1720     1720           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 07:08 codecov[bot]

/approve

sp1999 avatar Aug 20 '24 07:08 sp1999

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [abhay-krishna,sp1999]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 30 '24 18:08 eks-distro-bot