eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

doc: update Cilium validation

Open viktor-kurchenko opened this issue 1 year ago • 7 comments

  • Update docs/content/en/docs/tasks/workload/networking-and-security.md to use Cilium CLI instead of connectivity check YAML manifest.

viktor-kurchenko avatar Jul 16 '24 19:07 viktor-kurchenko

Hi @viktor-kurchenko. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-bot avatar Jul 16 '24 19:07 eks-distro-bot

@csplinter could you please review? Thanks!

viktor-kurchenko avatar Jul 30 '24 12:07 viktor-kurchenko

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.35%. Comparing base (7bd28f4) to head (96c9a62). Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8492      +/-   ##
==========================================
- Coverage   72.35%   72.35%   -0.01%     
==========================================
  Files         585      585              
  Lines       45686    45686              
==========================================
- Hits        33058    33055       -3     
- Misses      10890    10892       +2     
- Partials     1738     1739       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 12 '24 16:08 codecov[bot]

Instead of replacing the current validation steps, we can probably add the Cilium CLI as an alternative way to validate.

mitalipaygude avatar Aug 14 '24 21:08 mitalipaygude

Instead of replacing the current validation steps, we can probably add the Cilium CLI as an alternative way to validate.

I afraid we can't. The manifest https://docs.isovalent.com/v1.10/public/connectivity-check-eksa.yaml already deprecated and functionality moved in the Cilium CLI.

viktor-kurchenko avatar Aug 15 '24 08:08 viktor-kurchenko

hi 👋 - @mitalipaygude any updates on this? This is the only current supported way of validating the cluster connectivity.

Thank you.

auriaave avatar Sep 02 '24 12:09 auriaave

@joestringer: changing LGTM is restricted to collaborators

In response to this:

LGTM, thanks!

Given that the current instructions suggest to deploy a deprecated YAML that pulls an image with dozens of CVEs, I think that this is in the best interests of eks-anywhere users to leverage actively supported tooling for validating whether the environment is healthy or not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-bot avatar Nov 04 '24 18:11 eks-distro-bot

@viktor-kurchenko is this still good to merge or are there any more changes to this PR? If you're still interested in merging this, could you rebase with current changes on main? Thank you!

abhay-krishna avatar Jan 11 '25 18:01 abhay-krishna

@viktor-kurchenko is this still good to merge or are there any more changes to this PR? If you're still interested in merging this, could you rebase with current changes on main? Thank you!

Yes, I think it's still relevant. Rebased. Thanks!

viktor-kurchenko avatar Jan 12 '25 21:01 viktor-kurchenko

/lgtm /approve

abhay-krishna avatar Jan 14 '25 02:01 abhay-krishna

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Jan 14 '25 02:01 eks-distro-bot

/cherrypick release-0.21

abhay-krishna avatar Jan 14 '25 05:01 abhay-krishna

/cherrypick release-0.20

abhay-krishna avatar Jan 14 '25 05:01 abhay-krishna

/cherrypick release-0.19

abhay-krishna avatar Jan 14 '25 05:01 abhay-krishna

@abhay-krishna: new pull request created: #9165

In response to this:

/cherrypick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Jan 14 '25 05:01 eks-distro-pr-bot

@abhay-krishna: new pull request created: #9166

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Jan 14 '25 05:01 eks-distro-pr-bot

@abhay-krishna: new pull request created: #9167

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Jan 14 '25 05:01 eks-distro-pr-bot