eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

fix: close AWS config

Open testwill opened this issue 1 year ago • 3 comments

Issue #, if available:

Description of changes: close AWS config Testing (if applicable): test success Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

testwill avatar May 10 '24 07:05 testwill

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign d8660091 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar May 10 '24 07:05 eks-distro-bot

Hi @testwill. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-bot avatar May 10 '24 07:05 eks-distro-bot

Can you update the description section of this PR? the testing part as well

mitalipaygude avatar Jul 12 '24 23:07 mitalipaygude

@testwill Are you still working on this? Any updates from the last review?

abhay-krishna avatar Dec 22 '24 22:12 abhay-krishna

@testwill Are you still working on this? Any updates from the last review?

no

testwill avatar Dec 26 '24 12:12 testwill