eks-anywhere
eks-anywhere copied to clipboard
aws
Added instructions to update kubeconfig after manual certs renewal or cluster upgrade
Issue #, if available:
Description of changes:
- As a EKSA Cluster admin, I want to update kubeconfig file on Admin machine post renewing cluster certificates manually.
Testing (if applicable):
- not tested.
Documentation added/planned (if applicable): This pull request is documentation update
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chrisnegus for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @saiteja313. Thanks for your PR.
I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.38%. Comparing base (
7235fc3) to head (4907a68). Report is 14 commits behind head on main.
:exclamation: Current head 4907a68 differs from pull request most recent head 0cede55
Please upload reports for the commit 0cede55 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #7890 +/- ##
==========================================
- Coverage 73.42% 73.38% -0.04%
==========================================
Files 577 578 +1
Lines 35944 35995 +51
==========================================
+ Hits 26391 26415 +24
- Misses 7884 7906 +22
- Partials 1669 1674 +5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chrisnegus Addressed the gaps with new changes. Could you re-review when you get a chance please.
@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.
In response to this:
/cherry-pick release-0.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chrisnegus: #7890 failed to apply on top of branch "release-0.19":
Applying: added instructions to update kubeconfig
.git/rebase-apply/patch:79: trailing whitespace.
ls -ltr
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Falling back to patching base and 3-way merge...
Auto-merging docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
CONFLICT (content): Merge conflict in docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 added instructions to update kubeconfig
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick release-0.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.