eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Upgrade registry certificate in packages

Open tatlat opened this issue 11 months ago • 3 comments

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tatlat avatar Mar 21 '24 02:03 tatlat

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tatlat. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Mar 21 '24 02:03 eks-distro-bot

Codecov Report

Attention: Patch coverage is 75.64103% with 19 lines in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (249f20d) to head (76a651f). Report is 12 commits behind head on main.

Files Patch % Lines
pkg/curatedpackages/packageinstaller.go 0.00% 10 Missing :warning:
cmd/eksctl-anywhere/cmd/createcluster.go 0.00% 3 Missing :warning:
cmd/eksctl-anywhere/cmd/upgradecluster.go 0.00% 3 Missing :warning:
...g/workflows/management/upgrade_curated_packages.go 81.81% 2 Missing :warning:
pkg/dependencies/factory.go 95.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7881      +/-   ##
==========================================
- Coverage   73.42%   73.39%   -0.03%     
==========================================
  Files         577      578       +1     
  Lines       35944    35956      +12     
==========================================
  Hits        26391    26391              
- Misses       7884     7897      +13     
+ Partials     1669     1668       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 21 '24 22:03 codecov[bot]

/approve

tatlat avatar Jun 03 '24 16:06 tatlat

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Jun 03 '24 16:06 eks-distro-bot

/cherrypick release-0.19

abhay-krishna avatar Jun 05 '24 21:06 abhay-krishna

@abhay-krishna: #7881 failed to apply on top of branch "release-0.19":

Applying: upgrade packages workflow
Using index info to reconstruct a base tree...
M	Makefile
M	cmd/eksctl-anywhere/cmd/createcluster.go
M	pkg/dependencies/factory.go
M	pkg/dependencies/factory_test.go
M	pkg/task/task.go
M	pkg/workflows/interfaces/interfaces.go
M	pkg/workflows/interfaces/mocks/clients.go
M	pkg/workflows/management/create.go
M	pkg/workflows/management/create_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/workflows/management/create_test.go
Auto-merging pkg/workflows/management/create.go
CONFLICT (content): Merge conflict in pkg/workflows/management/create.go
Auto-merging pkg/workflows/interfaces/mocks/clients.go
CONFLICT (content): Merge conflict in pkg/workflows/interfaces/mocks/clients.go
Auto-merging pkg/workflows/interfaces/interfaces.go
Auto-merging pkg/task/task.go
Auto-merging pkg/dependencies/factory_test.go
Auto-merging pkg/dependencies/factory.go
Auto-merging cmd/eksctl-anywhere/cmd/createcluster.go
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 upgrade packages workflow
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Jun 05 '24 21:06 eks-distro-pr-bot