eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Helm chart.yaml fix PR

Open jonahjon opened this issue 3 years ago β€’ 3 comments

Signed-off-by: jonahjon [email protected]

Issue #, if available:

Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jonahjon avatar Sep 21 '22 21:09 jonahjon

Codecov Report

Merging #3415 (82a2a94) into main (b98e1b3) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3415   +/-   ##
=======================================
  Coverage   65.06%   65.06%           
=======================================
  Files         352      353    +1     
  Lines       28542    28562   +20     
=======================================
+ Hits        18570    18584   +14     
- Misses       8660     8666    +6     
  Partials     1312     1312           
Impacted Files Coverage Ξ”
pkg/api/v1alpha1/snowdatacenterconfig_webhook.go 50.00% <0.00%> (ΓΈ)
pkg/api/v1alpha1/cloudstackmachineconfig_types.go 63.12% <0.00%> (+2.19%) :arrow_up:
pkg/kubeconfig/kubeconfig.go 100.00% <0.00%> (+4.65%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 21 '22 21:09 codecov[bot]

/lgtm

panktishah26 avatar Sep 28 '22 16:09 panktishah26

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Sep 28 '22 17:09 eks-distro-bot

/test eks-anywhere-e2e-presubmit

panktishah26 avatar Sep 28 '22 18:09 panktishah26

/test eks-anywhere-e2e-presubmit

jonahjon avatar Sep 28 '22 19:09 jonahjon

/cherrypick release-0.11

jonahjon avatar Sep 28 '22 19:09 jonahjon

@jonahjon: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Sep 28 '22 19:09 eks-distro-pr-bot

/retest

jonahjon avatar Sep 28 '22 19:09 jonahjon

/test eks-anywhere-e2e-presubmit

jonahjon avatar Sep 28 '22 20:09 jonahjon

/lgtm

jiayiwang7 avatar Sep 28 '22 20:09 jiayiwang7

@jonahjon: new pull request created: #3484

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eks-distro-pr-bot avatar Sep 28 '22 20:09 eks-distro-pr-bot