eks-anywhere
eks-anywhere copied to clipboard
Adding tools to fetch external etcd cluster from EKS-A Controller
Issue #, if available: https://github.com/aws/eks-anywhere/issues/2260
Description of changes: This PR adds the functions for the EKS-A controller to reconcile upgrades and consider an external etcd cluster.
Testing (if applicable): Successfully scaled cluster with changes from https://github.com/aws/eks-anywhere/pull/2938, unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jacobweinstock for approval by writing /assign @jacobweinstock in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Merging #3392 (bc86fe6) into main (308eca2) will increase coverage by
0.17%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #3392 +/- ##
==========================================
+ Coverage 64.73% 64.91% +0.17%
==========================================
Files 352 352
Lines 28264 28387 +123
==========================================
+ Hits 18298 18427 +129
+ Misses 8654 8648 -6
Partials 1312 1312
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/controller/clusterapi.go | 100.00% <100.00%> (ø) |
|
| pkg/controller/clusters/clusterapi.go | 100.00% <100.00%> (ø) |
... and 12 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
As far as I'm aware this work is now being captured in the lifecycle controller project for CloudStack, @ddjjia can correct me if I'm wrong. Closing this PR out.