eks-anywhere
eks-anywhere copied to clipboard
Adding api builder for cloudstack machine templates and machine deployments
Issue #, if available: https://github.com/aws/eks-anywhere/issues/2260
Description of changes: First PR of many covering changes required to support full lifecycle API controller. This moves the cloudstackmachinetemplate generation for control planes to use the apibuilder instead of templating.
Testing (if applicable):
- unit tests
- successfully ran 1.20->1.21 E2E test locally
- Successfully scaled cluster with changes from https://github.com/aws/eks-anywhere/pull/2938
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Merging #3386 (8dad5e1) into main (fef9c41) will decrease coverage by
0.05%. The diff coverage is86.60%.
@@ Coverage Diff @@
## main #3386 +/- ##
==========================================
- Coverage 67.48% 67.43% -0.06%
==========================================
Files 376 378 +2
Lines 30938 31066 +128
==========================================
+ Hits 20880 20949 +69
- Misses 8673 8730 +57
- Partials 1385 1387 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/providers/cloudstack/cloudstack.go | 71.17% <58.33%> (-0.44%) |
:arrow_down: |
| pkg/providers/cloudstack/apibuilder.go | 100.00% <100.00%> (ø) |
|
| pkg/curatedpackages/reader.go | 45.88% <0.00%> (-43.53%) |
:arrow_down: |
| pkg/curatedpackages/curatedpackages.go | 50.58% <0.00%> (-1.18%) |
:arrow_down: |
| pkg/api/v1alpha1/cluster.go | 73.26% <0.00%> (-0.39%) |
:arrow_down: |
| controllers/resource/template.go | 37.78% <0.00%> (-0.36%) |
:arrow_down: |
| pkg/providers/vsphere/vsphere.go | 63.16% <0.00%> (ø) |
|
| pkg/providers/vsphere/hook.go | 0.00% <0.00%> (ø) |
|
| pkg/clustermanager/cluster_manager.go | 67.21% <0.00%> (+0.27%) |
:arrow_up: |
| ... and 6 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/hold until CAPC v0.4.8 is released and built into EKS-A
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vivek-koppuru
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vivek-koppuru]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment