clusterctl move retry

[jweite-amazon]

Issue #, if available:

Description of changes: Changes to enable retry of clusterctl move on networking-related failures.

• Wrap clusterctl move in exponential backoff retrier with 30m timeout.
• Unit test of retry on network-related failure.
• Factor pseudo-consts declared in kubectl.go to constants.go when retries were implemented there, for use in other places (like clusterctl.go)

Near identical approach to retries of kubectl wait, recently added.

Testing (if applicable): Unit test of retry functionality added.
Expected retry behavior also confirmed via debugger.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov[bot]]

Codecov Report

Merging #3324 (3bdfb3e) into main (df02826) will increase coverage by 0.42%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3324      +/-   ##
==========================================
+ Coverage   64.46%   64.88%   +0.42%     
==========================================
  Files         352      352              
  Lines       28019    28418     +399     
==========================================
+ Hits        18062    18439     +377     
- Misses       8648     8666      +18     
- Partials     1309     1313       +4     

Impacted Files	Coverage Δ
pkg/executables/clusterctl.go	72.13% <100.00%> (+1.95%)	:arrow_up:
pkg/executables/kubectl.go	45.79% <100.00%> (+0.79%)	:arrow_up:
pkg/bootstrapper/retrier_client.go	50.00% <0.00%> (-50.00%)	:arrow_down:
pkg/bootstrapper/bootstrapper.go	52.87% <0.00%> (-9.77%)	:arrow_down:
pkg/cluster/snow.go	68.54% <0.00%> (-2.42%)	:arrow_down:
pkg/cluster/spec.go	63.47% <0.00%> (-0.92%)	:arrow_down:
controllers/resource/fetcher.go	40.26% <0.00%> (-0.56%)	:arrow_down:
controllers/snow_machineconfig_controller.go	89.28% <0.00%> (-0.55%)	:arrow_down:
pkg/providers/docker/docker.go	67.75% <0.00%> (-0.48%)	:arrow_down:
pkg/workflows/upgrade.go	64.59% <0.00%> (-0.41%)	:arrow_down:
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[maxdrib]

/cherrypick release-0.11

[eks-distro-pr-bot]

@maxdrib: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[g-gaston]

/lgtm

[jweite-amazon]

/approve

[abhay-krishna]

/approve

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, jweite-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [abhay-krishna]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[eks-distro-pr-bot]

@maxdrib: new pull request created: #3453

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.