eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Cp cli dry kubeconfig checking

Open ewollesen opened this issue 3 years ago • 4 comments

Issue #, if available:

Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ewollesen avatar Sep 08 '22 21:09 ewollesen

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

eks-distro-bot avatar Sep 08 '22 21:09 eks-distro-bot

/hold

Until aws/eks-anywhere#3309 is merged

ewollesen avatar Sep 08 '22 21:09 ewollesen

Codecov Report

Merging #3311 (4fba0af) into main (6cb99f3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3311   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files         351      351           
  Lines       28507    28507           
=======================================
  Hits        18532    18532           
  Misses       8662     8662           
  Partials     1313     1313           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 08 '22 21:09 codecov[bot]

/unhold

ewollesen avatar Sep 26 '22 22:09 ewollesen

/approve

ewollesen avatar Sep 26 '22 23:09 ewollesen

/approve /lgtm

a-cool-train avatar Sep 26 '22 23:09 a-cool-train

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-cool-train, ewollesen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [a-cool-train,ewollesen]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Sep 26 '22 23:09 eks-distro-bot

/retest

Trying a retest, since the details indicate that the process timed out, which leads me to believe it was a transient failure.

ewollesen avatar Sep 27 '22 16:09 ewollesen

/unhold

ewollesen avatar Sep 27 '22 18:09 ewollesen

Another retest, as the last two have now hung up, but I'm told there are new settings in the script that add a timeout. I've been looking but don't have much to go on as to "why" though. :(

/retest

ewollesen avatar Sep 27 '22 20:09 ewollesen

/retest

My last command seemed to have been ignored?

ewollesen avatar Sep 27 '22 21:09 ewollesen