Set bundles refs when it's not specified

[wongni]

Issue #, if available:

Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign markapruett after the PR has been reviewed. You can assign the PR to them by writing /assign @markapruett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[codecov[bot]]

Codecov Report

Merging #3239 (151ea64) into main (b1dd4d2) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3239      +/-   ##
==========================================
- Coverage   64.05%   64.02%   -0.03%     
==========================================
  Files         347      347              
  Lines       27584    27596      +12     
==========================================
  Hits        17668    17668              
- Misses       8611     8622      +11     
- Partials     1305     1306       +1     

Impacted Files	Coverage Δ
controllers/resource/reconciler.go	43.71% <0.00%> (-3.39%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[g-gaston]

Interesting. How would the system reach this state? In order to use the new version of the code, the user has to run an upgrade command. And that upgrade command will set the bundles ref if it's null.

[maxdrib]

Interesting. How would the system reach this state? In order to use the new version of the code, the user has to run an upgrade command. And that upgrade command will set the bundles ref if it's null.

I agree @g-gaston, the system should not be in this state. I think the real issue we've observed stems from this fallback logic: https://github.com/aws/eks-anywhere/blob/main/pkg/cluster/fetch.go#L78-L84

If a cluster is running the new EKS-A, I don't think it makes sense to fall back to legacy bundles and trigger a confusing rollback. Instead, it makes more sense to throw an error, since the BundlesRef field is now a required field.

[TerryHowe]

Reopen if there is something here. Sounds like this "shouldn't happen"